Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210401091648.87421-1-puranjay12@gmail.com> <20210401091648.87421-3-puranjay12@gmail.com>
 <CAHp75Vcmyvi4V2D0cnmobTGHCS_ci2FC=cBF8tEoG9v51o8RmQ@mail.gmail.com> <0d2bce88-1c23-a711-6a37-118173066ab5@metafoo.de>
In-Reply-To: <0d2bce88-1c23-a711-6a37-118173066ab5@metafoo.de>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 3 Apr 2021 16:52:34 +0300
Message-ID: <CAHp75Vfu6B=p7XRx6Ca2tiwVzSgs8YOuyvYJ63cOrYZxDOYdSg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] iio: temperature: add driver support for ti tmp117
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     Puranjay Mohan <puranjay12@gmail.com>,
        Alexandru Ardelean <alexandru.ardelean@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Apr 2, 2021 at 11:14 AM Lars-Peter Clausen <lars@metafoo.de> wrote:
>
> On 4/1/21 11:36 AM, Andy Shevchenko wrote:
> > [...]
> >> +       case IIO_CHAN_INFO_SCALE:
> >> +               /* Conversion from 10s of uC to mC
> >> +                * as IIO reports temperature in mC
> >> +                */
> >> +               *val = TMP117_RESOLUTION_10UC / 10000;
> >> +               *val2 = (TMP117_RESOLUTION_10UC % 10000) * 100;
> >> +               return IIO_VAL_INT_PLUS_MICRO;
> > You use 10000 many times, can you give it an appropriate name (via #define)?
> #define TENTHOUSAND 10000 ;)

Actually, besides April fool's day, this can have a value if 1000 is
defined as mC _PER_uC or so.
Oh, wait. We have it already.

#define MILLIDEGREE_PER_DEGREE 1000


--
With Best Regards,
Andy Shevchenko