Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <eb2db42b7e721e6fbeaf8324d33801b5a9bfc03a.camel@perches.com>
Subject: Re: [PATCH v3 23/30] staging: rtl8723bs: fix comparison in if
 condition in core/rtw_recv.c
From:   Joe Perches <joe@perches.com>
To:     Fabio Aiuto <fabioaiuto83@gmail.com>, gregkh@linuxfoundation.org
Cc:     dan.carpenter@oracle.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Date:   Sat, 03 Apr 2021 08:24:12 -0700
In-Reply-To: <5acf0d9573f2d9cd5d249f928fbfeee010f5f3fc.1617440834.git.fabioaiuto83@gmail.com>
References: <cover.1617440833.git.fabioaiuto83@gmail.com>
         <5acf0d9573f2d9cd5d249f928fbfeee010f5f3fc.1617440834.git.fabioaiuto83@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sat, 2021-04-03 at 11:13 +0200, Fabio Aiuto wrote:
> fix post-commit checkpatch issue:
> 
> CHECK: Using comparison to false is error prone
> 27: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381:
> +				if (psecuritypriv->
> 			bcheck_grpkey == false &&
> 
> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> ---
> ?drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index cd4324a93275..21949925ec77 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -378,7 +378,7 @@ static signed int recvframe_chkmic(struct adapter *adapter,  union recv_frame *p
> ?
> 
> ?			} else {
> ?				/* mic checked ok */
> -				if (psecuritypriv->bcheck_grpkey == false &&
> +				if (!psecuritypriv->bcheck_grpkey &&
> ?				    (IS_MCAST(prxattrib->ra) == true))
> ?					psecuritypriv->bcheck_grpkey = true;
> ?			}