Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2474187pxf; Sun, 4 Apr 2021 02:58:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzdMSX5eZrNB1P8dgKhMhM4NjQ/oeK6qtdfAPGUdZDpwNo+TK7a5J8dexqWObBVs4YCWexw X-Received: by 2002:a92:cd89:: with SMTP id r9mr16158286ilb.1.1617530318607; Sun, 04 Apr 2021 02:58:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617530318; cv=none; d=google.com; s=arc-20160816; b=rXaHJPEN9PfdBn4qZbRU2E9oixGkraRZkqhBKy3h5cU6d4k5kckOYtOIWwu1Fu8VIZ 2TZc6IJbii02lOfuv5V72Vhh94sQ6cZHatc52sYmuU1Z/w6UoZbEhGcSZiUQuncasN6Z MVirClBK/j6CfRXdfF02qAB1lPzGrD3D9y9Db3Mm4wSMqoWguPniXTxKFhpa6yZgRuWT 4R4oKjXU2X0sBhmpjun/9Ig3RFESyAmw34AypEiiD6TqLwntigc6Aa3HmR0euOyDEAwQ QWTfMx94piqUmYUjjEVz5fxBPlM+50YmQaOwFEKLogRxIJ1XQBf24H3tNLCaaVpgNvzo YWtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LSTN9BneyB+MbyqVb+KDdztCojFYmCgmqi0Te/+GcD8=; b=XFhsSwiWKv8IEVS/pvBD8ppPzIQkIImbjVhHZcDUgpYGHnzkNXJn/LxlWUYH/uwMd0 YDGwgap4gBFL9Nw1yu6GMh/rZs2LNth0mQ+XpnhZ2xalkLqcMikpZZ1LP0/C8nRW3X/1 E39BpT/a1+/OQEzwtVQi1ZUJBDvUp+xaaXAKIKC+g+sWGjvKbN5Ecf5NULiq8bv2Rm4b ZYJcNU+nJ66uQ4mzDsQT1b0vluuGsWSDPeYhBtnqFdCBIJyHzT2uA2VFAle3G3nT89ta jPX6V+uTVurolaDGZSf86EXo8/PTcpCIf3VgqTkSgZM/Qgun7/2eRzvPL2vhzA56bPu8 pt4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nB1qT3Vp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n14si13687554jaj.25.2021.04.04.02.58.24; Sun, 04 Apr 2021 02:58:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nB1qT3Vp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbhDDJ4s (ORCPT + 99 others); Sun, 4 Apr 2021 05:56:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:49970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbhDDJ4r (ORCPT ); Sun, 4 Apr 2021 05:56:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C0F4661380; Sun, 4 Apr 2021 09:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617530203; bh=73hP+jEaoOThuXHQz9FoAHAQEROgVEtTny858He9dRY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nB1qT3VpR+ESVGTlYaK/nDen1ypyZifEgww/pPz7bOL6BN93VuEWJ2b71vUp96J6R nO6v6wkgyogp/tgjJhRKJqCUj6FNUL40O3Qz0IBoJtnKcHvGEa21HR0MKgM+GEz7Wt /hl36ExET76WwZokZnGpsMhLJfaaSjD0NEADjj4w= Date: Sun, 4 Apr 2021 11:56:40 +0200 From: Greg Kroah-Hartman To: Ivan Safonov Cc: Larry Finger , Michael Straube , "Gustavo A. R. Silva" , Peilin Ye , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging:r8188eu: remove dummy handlers from OnAction() Message-ID: References: <20210328163323.53163-1-insafonov@gmail.com> <20210328163323.53163-2-insafonov@gmail.com> <8955077a-94b6-9ffb-d2f6-b611845b6cfc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8955077a-94b6-9ffb-d2f6-b611845b6cfc@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 04, 2021 at 12:30:41AM +0300, Ivan Safonov wrote: > On 4/2/21 4:04 PM, Greg Kroah-Hartman wrote: > > On Sun, Mar 28, 2021 at 07:33:25PM +0300, Ivan Safonov wrote: > > > on_action_spct() do nothing, because rtw_get_stainfo() has no side > > > effects. Other action handlers are trivial. > > > > > > Signed-off-by: Ivan Safonov > > > > Same here, wrong driver name :( > > > > Driver name is "r8188eu"... > > $ grep 'r8188eu' drivers/staging/rtl8188eu/include/drv_types.h Directory name is "rtl8188eu", so something needs to be fixed up here to remove confusion like this :) thanks, greg k-h