Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2594239pxf; Sun, 4 Apr 2021 07:11:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkrTNlFzAXwvQcVcpq93xl5xJC+Ar90zR/Lh50g29aBO85qochWdlJVk9kjzuuV/WoBXA6 X-Received: by 2002:aa7:d4ca:: with SMTP id t10mr26079399edr.388.1617545465701; Sun, 04 Apr 2021 07:11:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617545465; cv=none; d=google.com; s=arc-20160816; b=FGmDV36cCWp2R0QtWBlwl9sM0XTwxBOQpvNwTsdYTe1Sljm1KMM2Tnga/9nDpF+/a+ 0IGjT4Ltl0sRQOfKJ3gLhEsMUuEBGB1xuRpJ1fc9YxeoJA0bWnZdSDW9XfT3LkmOWRBY eky8tIfKhHeqsvbP3PxmD6i5ufJGSwVlMblzLAPZcPqJMj9jIPtjD+y3I0bM5WMim6Yb ZoEzcGIcXzlbG3gkPQ2rWIJvnzDZ3TGzMEA4ErBVMXSHhPq4IK+Nq/8pcKB3A6+QHmIj qQuvBK0tG2OKulYs4XlpeKA1FmS1xXDQMiaOsuFCVFHfdOQ/RaK76JPiG7zNqPunFXSS 8Y+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eVLSD6TsWDnyVwfKOiwMsJMVRC8hKmFN/FvLWADHKVg=; b=oCX/UmS+g4iuERoihWrbcI+tnoOAwWT/Je2VVyBM7rFpmtRRj5O8yp2OqZHULEa6qS NME3O2WgiDR6A0ZOKE4aV5+MB7csIh8cB+ZKujLJasjuprLpjKrdaOotxRMN1HAWN95q c4ek58vz2+VMGjNum7ISrl+1Ozwi7IaMYFcVyTJol3czhDlrUplVOGv9yVKQV09kEP82 BEBGVRIQwXYJ+XsgDh4uHwLXmhABIAGbJKz20/w7m/JuBVIrxc6uwOBjRza9eOTD+2XX fkp532efb5xG6A/g1/NTUMIEtnaLBfZG5MLCih4Pd6dNGfoi0geBj8CimcVTJ+FdwWf+ itpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=i+oLZ2SW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r1si11002717edp.303.2021.04.04.07.10.43; Sun, 04 Apr 2021 07:11:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=i+oLZ2SW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231142AbhDDOKC (ORCPT + 99 others); Sun, 4 Apr 2021 10:10:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231129AbhDDOKA (ORCPT ); Sun, 4 Apr 2021 10:10:00 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 519FEC061756 for ; Sun, 4 Apr 2021 07:09:55 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id j4-20020a05600c4104b029010c62bc1e20so4472326wmi.3 for ; Sun, 04 Apr 2021 07:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eVLSD6TsWDnyVwfKOiwMsJMVRC8hKmFN/FvLWADHKVg=; b=i+oLZ2SWvghTyp5CK70LCoOflb9OJrNJO0xhxTyAfPy9hmtH+QY4AdFf0OrrR9T4dX mQ3TW4JJXkSVenFI6IauMmQRmESB9lIJp6vRntkwN3QWnhJwnRIBUf+pVZihFj2bYWCC 4N9Wgpyggs2F83VIMo4p0+P7sSl2+WzANvrU/pLCDoIUGyxmUZ7dITTK1s7DLUqDnjKl P7qpsPW345TJVTTD2rdPxk/RZRbEwW4aIjahZA1JxLQIjcJVOTzt2HhMBCZwENeJqDfE fKW6GSjrmcaW9Wie+z6fa3h4Xy85pJkzdijKHRRz6bmfX+ZQulLPLVtTbnO48BgiDGBr 0C4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eVLSD6TsWDnyVwfKOiwMsJMVRC8hKmFN/FvLWADHKVg=; b=N/YaDuT1ALX/UcLtUB1yjNjo/hEzmpmMWTTe5x5/0LngV6l4DQySzicsZ8j/qVRvas da8ZxHy9O13C+jlPTUeDVmjVx06ZE3Xh5ImyEsBD4AnVhAbz2Yzo0kcObURxLcZtJ8aj fmWFdTACMjRdrV+aWGiMQLE3RrYXxLxx8Z5jDt5o2dAV+pSNrjbLaWCRjMjLXagcbtFH o7qFnc2jL1Ush8VrglL376Sihdv/tkiofcyOvlz+yZ7Aqj21cB/aXQO6x6dL4d85V5K2 Cl9ttKLcnqJK4rSp32VM1gCYkOVwFgRL/l44WvRBzGua387wJfa7bpXlEPNXhyL7cLYq ZpCQ== X-Gm-Message-State: AOAM532krUDnntAwqXTqkMJthfIYxkHEpafg6+ps6siXAwnCyR4iXC0l nRqKoHrk+XM7oUI7zn7t1bK3jN72kGeDlw== X-Received: by 2002:a7b:c214:: with SMTP id x20mr21369149wmi.186.1617545394102; Sun, 04 Apr 2021 07:09:54 -0700 (PDT) Received: from agape ([5.171.81.112]) by smtp.gmail.com with ESMTPSA id 61sm12616126wrn.25.2021.04.04.07.09.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Apr 2021 07:09:53 -0700 (PDT) From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: dan.carpenter@oracle.com, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Fabio Aiuto Subject: [PATCH v4 02/30] staging: rtl8723bs: fix condition in if statement in core/rtw_xmit.c Date: Sun, 4 Apr 2021 16:09:18 +0200 Message-Id: <45793b555f46312ea3c9cd285886dec22f3a1131.1617545239.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix post-commit hook checkpatch issue: CHECK: Using comparison to true is error prone 71: FILE: drivers/staging/rtl8723bs/core/rtw_xmit.c:565: + ((padapter->securitypriv.sw_encrypt == true) || (psecuritypriv->hw_decrypted == false))) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index beee87db85a5..957d7e3a4d4a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -562,7 +562,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p memcpy(pattrib->dot118021x_UncstKey.skey, psta->dot118021x_UncstKey.skey, 16); if (pattrib->encrypt && - ((padapter->securitypriv.sw_encrypt == true) || (psecuritypriv->hw_decrypted == false))) + ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted))) pattrib->bswenc = true; else pattrib->bswenc = false; -- 2.20.1