Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030235AbWJKLXK (ORCPT ); Wed, 11 Oct 2006 07:23:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030331AbWJKLXK (ORCPT ); Wed, 11 Oct 2006 07:23:10 -0400 Received: from brick.kernel.dk ([62.242.22.158]:10564 "EHLO kernel.dk") by vger.kernel.org with ESMTP id S1030235AbWJKLXI (ORCPT ); Wed, 11 Oct 2006 07:23:08 -0400 Date: Wed, 11 Oct 2006 13:23:14 +0200 From: Jens Axboe To: Vasily Tarasov Cc: Linux Kernel Mailing List , OpenVZ Developer List Subject: Re: [PATCH] block layer: elv_iosched_show should get elv_list_lock Message-ID: <20061011112314.GP6515@kernel.dk> References: <200610111119.k9BBJhls004763@vass.7ka.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200610111119.k9BBJhls004763@vass.7ka.mipt.ru> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 656 Lines: 20 On Wed, Oct 11 2006, Vasily Tarasov wrote: > elv_iosched_show function iterates other elv_list, > hence elv_list_lock should be got. Indeed, that's a bug. Thanks! > Also the question is: in elv_iosched_show, elv_iosched_store > q->elevator->elevator_type construction is used without locking > q->queue_lock. Is it expected?.. As long as the queue doesn't go away, we should be safe enough. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/