Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <ME4P282MB1174C26FCD8E61817960F596C0789@ME4P282MB1174.AUSP282.PROD.OUTLOOK.COM>
In-Reply-To: <ME4P282MB1174C26FCD8E61817960F596C0789@ME4P282MB1174.AUSP282.PROD.OUTLOOK.COM>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Sun, 4 Apr 2021 17:16:26 -0700
Message-ID: <CAEf4BzZyyQLchpK9OjH3A5N5-eKNBq0t7p2fvuPbGVty3gFh5g@mail.gmail.com>
Subject: Re: [PATCH] libbpf: Fix KERNEL_VERSION macro
To:     Hengqi Chen <chenhengqi@outlook.com>
Cc:     bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Networking <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Apr 4, 2021 at 2:53 AM Hengqi Chen <chenhengqi@outlook.com> wrote:
>
> Add missing ')' for KERNEL_VERSION macro.
>
> Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
> ---

The fix looks good, thank you. But your patch didn't make it into
bpf/netdev patchworks instance ([0]) most probably due to too long CC
list. Can you please re-send with just maintainers and bpf@ and
netdev@ mailing lists in to/cc.

Also for bpf and bpf-next tree, we ask to specify the tree with [PATCH
bpf-next] prefix, so when re-submitting please adjust as well. Thanks.

  [0] https://patchwork.kernel.org/project/netdevbpf/list/

>  tools/lib/bpf/bpf_helpers.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/bpf_helpers.h b/tools/lib/bpf/bpf_helpers.h
> index cc2e51c64a54..b904128626c2 100644
> --- a/tools/lib/bpf/bpf_helpers.h
> +++ b/tools/lib/bpf/bpf_helpers.h
> @@ -51,7 +51,7 @@
>  #endif
>
>  #ifndef KERNEL_VERSION
> -#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + ((c) > 255 ? 255 : (c))
> +#define KERNEL_VERSION(a, b, c) (((a) << 16) + ((b) << 8) + ((c) > 255 ? 255 : (c)))
>  #endif
>
>  /*
> --
> 2.25.1
>