Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2926410pxf; Sun, 4 Apr 2021 20:39:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxleYh2Yqn121dMnDotQ/DgJCEoOTMGCyiulZQCAFyEv5ZyM+mmrm/XivYyrrOs3qdipRvU X-Received: by 2002:a17:907:9709:: with SMTP id jg9mr25587550ejc.276.1617593971420; Sun, 04 Apr 2021 20:39:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617593971; cv=none; d=google.com; s=arc-20160816; b=h0RrgsLsjxBVJ4reoMlOtnmnGP0q509iRKF9IhjSfyqfxu0rDrs5f1bGv9eF9SlW79 4EWd1hGwlmYXBwo5IoWVhAlc9wrF40ehWbJ5nQo6kuEOeSZ1kC2ZFGunDzvLhXA1SXNV GatJeP6s7QYYpe5ekXAi4+vy2762KIrRTDI6TrjbSclS3Ad3Yylmz6csqP/CEKryMZqa GntCoi8C8eGPeMeafO974fr/rIdTFKvYSBz/7I/NGH4GJG3IUOBr/XVZI62/Ke5S/3pu KgEiRHMjOj16xSubt8J3K2JYR21Yauhv1wYLW5RHutfHIozIuYM5Udztqw/XYCSGeRQx 5Ziw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=as/0Z/5wr9TkrGQbVDRqvZhLAp0fADIbecLscNasQB0=; b=m7XUspHA2lFrRIIeAv1zSV5yOpfP0hZaCV0QWPPo7NegEkWnMLellHJQKiA1Usx4Jy q6oUZNYiWXwace8BssQlPNMP/0MJlhWIKgVrO1BR2SfBbK9CkB9fa3GdI/PI8kYrU2HO C9A0Wb8vO4SXTC7ZLdl9vXawsbDiG3Rp5SCCJnHgcvMuQ0yEq2rAvPzBbjY8awM7zOf0 cpYQMFJPGoDA87EM0mWJbSjczQnF+fkJKZYkYsQvKnfQbmuxm98NlgITbl81BWJ23qgW bAnznuYce7SnU0kRlcZD5sBz5cseLDAI4DGQLBjbwtrzgWeqxPP/Qk71BvIPOOS5ozcO FCLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i25si12577872edt.491.2021.04.04.20.39.08; Sun, 04 Apr 2021 20:39:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231954AbhDEDhN (ORCPT + 99 others); Sun, 4 Apr 2021 23:37:13 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:15907 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231934AbhDEDhK (ORCPT ); Sun, 4 Apr 2021 23:37:10 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FDGWT6n8Gzkhb9; Mon, 5 Apr 2021 11:35:17 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Mon, 5 Apr 2021 11:36:56 +0800 From: Xiaofei Tan To: , CC: , , Xiaofei Tan Subject: [PATCH 03/10] tty: tty_jobctrl: Add a blank line after declarations Date: Mon, 5 Apr 2021 11:34:15 +0800 Message-ID: <1617593662-25900-4-git-send-email-tanxiaofei@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1617593662-25900-1-git-send-email-tanxiaofei@huawei.com> References: <1617593662-25900-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/tty/tty_jobctrl.c b/drivers/tty/tty_jobctrl.c index 4b751b9..86070f7 100644 --- a/drivers/tty/tty_jobctrl.c +++ b/drivers/tty/tty_jobctrl.c @@ -75,6 +75,7 @@ void proc_clear_tty(struct task_struct *p) { unsigned long flags; struct tty_struct *tty; + spin_lock_irqsave(&p->sighand->siglock, flags); tty = p->signal->tty; p->signal->tty = NULL; @@ -173,6 +174,7 @@ EXPORT_SYMBOL_GPL(get_current_tty); void session_clear_tty(struct pid *session) { struct task_struct *p; + do_each_pid_task(session, PIDTYPE_SID, p) { proc_clear_tty(p); } while_each_pid_task(session, PIDTYPE_SID, p); @@ -269,6 +271,7 @@ void disassociate_ctty(int on_exit) tty_vhangup_session(tty); } else { struct pid *tty_pgrp = tty_get_pgrp(tty); + if (tty_pgrp) { kill_pgrp(tty_pgrp, SIGHUP, on_exit); if (!on_exit) @@ -280,6 +283,7 @@ void disassociate_ctty(int on_exit) } else if (on_exit) { struct pid *old_pgrp; + spin_lock_irq(¤t->sighand->siglock); old_pgrp = current->signal->tty_old_pgrp; current->signal->tty_old_pgrp = NULL; @@ -328,6 +332,7 @@ void no_tty(void) between a new association and proc_clear_tty but possible we need to protect against this anyway */ struct task_struct *tsk = current; + disassociate_ctty(0); proc_clear_tty(tsk); } -- 2.8.1