Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2958026pxf; Sun, 4 Apr 2021 22:02:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/A+fvFmhCK6K0qq8M0vJYHi9D6ghXDmZd6wSP+0GPGKQQBwiG0MtWuLyHXDhBqR5TUMl0 X-Received: by 2002:a05:6602:2012:: with SMTP id y18mr17715107iod.169.1617598971922; Sun, 04 Apr 2021 22:02:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617598971; cv=none; d=google.com; s=arc-20160816; b=uIxJJMK3u+RkajmMO8g6PP9lQvvzi/3YYvptdA2UjC8wdgliSd7Swq6DO8JqrdCRDT yEky/gilUycR/Ykoau6Yb0DeiHWVZ177qW4QAwPRlqyuDMcPA+NgoHp9oGd10JoJpAP2 fxYoD/kaNyMvSdyIUwc5yi0u/NM5+MOzWTcbmt0KrADdV58TVGbdEMBc5Oz+RCYG6e8R jYAI0KuGfbXSGTOl3HZDDrMLy/voabrlNnEalT2ZiZT6SzYU0F+FNjdkZ/tWWC1jvVln v1hp/smpMPhkH7/7Lxn5F1l7N7Z3Y2j4huOMEtv41DEH7yLtZ8NK+NaPei4UHF0PHfcQ Z3Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=JciwB1t+diBUkRQGYQmBXUZLd+r5hQbK4h7wzHIzf1Y=; b=wF1yqyvjR9mI57tN5k3HWcPyPucitEZ3FKW44CYCxS4y+dXjrkYi6lms3A7JF+1Mk6 AmBmGPZ2dYyVRF53KIAY8QD2ZzkwP82MoFsHIHKWEcw3XzTmgPtg/7loee+8s5Ooi4cw cQM5ocQbOl2BvxpD5xmSwNqKJm2i/ewxUPgOPqWW+7Xr4hFBlI6ofDpkmJvyObxXKZbv yK6nwfiHjAFq4+IBOX++RS+uWHQnLEmbfXvcRKAeZws1t+/mtLlB2H92KacDMncGrS7K n3gf3N3oIrzvpDVzKWLD1PcK6k2aK9lSlcX1RFMTizfQde3EvxefKrmekrKCzbbJgMM4 JJ9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j3si12647141jam.97.2021.04.04.22.02.38; Sun, 04 Apr 2021 22:02:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231980AbhDEDhR (ORCPT + 99 others); Sun, 4 Apr 2021 23:37:17 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:15908 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231833AbhDEDhL (ORCPT ); Sun, 4 Apr 2021 23:37:11 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FDGWT6Wwvzkhb1; Mon, 5 Apr 2021 11:35:17 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Mon, 5 Apr 2021 11:36:57 +0800 From: Xiaofei Tan To: , CC: , , Xiaofei Tan Subject: [PATCH 04/10] tty: tty_jobctrl: Fix coding style issues of block comments Date: Mon, 5 Apr 2021 11:34:16 +0800 Message-ID: <1617593662-25900-5-git-send-email-tanxiaofei@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1617593662-25900-1-git-send-email-tanxiaofei@huawei.com> References: <1617593662-25900-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix coding style issues of block comments, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/tty/tty_jobctrl.c b/drivers/tty/tty_jobctrl.c index 86070f7..4d78422 100644 --- a/drivers/tty/tty_jobctrl.c +++ b/drivers/tty/tty_jobctrl.c @@ -204,8 +204,10 @@ int tty_signal_session_leader(struct tty_struct *tty, int exit_session) spin_lock_irq(&p->sighand->siglock); if (p->signal->tty == tty) { p->signal->tty = NULL; - /* We defer the dereferences outside fo - the tasklist lock */ + /* + * We defer the dereferences outside fo + * the tasklist lock + */ refs++; } if (!p->signal->leader) { @@ -328,9 +330,11 @@ void disassociate_ctty(int on_exit) */ void no_tty(void) { - /* FIXME: Review locking here. The tty_lock never covered any race - between a new association and proc_clear_tty but possible we need - to protect against this anyway */ + /* + * FIXME: Review locking here. The tty_lock never covered any race + * between a new association and proc_clear_tty but possible we need + * to protect against this anyway + */ struct task_struct *tsk = current; disassociate_ctty(0); @@ -536,7 +540,7 @@ static int tiocgsid(struct tty_struct *tty, struct tty_struct *real_tty, pid_t _ /* * (tty == real_tty) is a cheap way of * testing if the tty is NOT a master pty. - */ + */ if (tty == real_tty && current->signal->tty != real_tty) return -ENOTTY; -- 2.8.1