Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 5 Apr 2021 08:37:13 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Min Li <min.li.xe@renesas.com>
Cc:     "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
        "dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management
 Unit (SMU) support
Message-ID: <YGqwGeSCdJwH33od@kroah.com>
References: <1617487714-8312-1-git-send-email-min.li.xe@renesas.com>
 <1617487714-8312-2-git-send-email-min.li.xe@renesas.com>
 <YGmQKyweNi3lWoGM@kroah.com>
 <OSBPR01MB477323303D45865B0B2AD96CBA779@OSBPR01MB4773.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <OSBPR01MB477323303D45865B0B2AD96CBA779@OSBPR01MB4773.jpnprd01.prod.outlook.com>
Precedence: bulk

On Mon, Apr 05, 2021 at 01:52:39AM +0000, Min Li wrote:
> > 
> > Any specific reason you are not using the misc_device api?  That would clean
> > up this driver a lot, there's no need to create a whole class just for a single
> > driver.
> > 
> 
> Hi Greg
> 
> No specific reason. I just didn't know the existence of misc_register API. 

Your file is in drivers/misc/ :)

> Do you recommend using this API to create the device?

Yes.

> If yes, can you tell me how to obtain a appropriate MINOR number from
> miscdevice.h?

No need to reserve one, we don't do that anymore, just ask for a dynamic
value and the next availble one will be given to your driver
automatically.

thanks,

greg k-h