Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nava kishore Manne <navam@xilinx.com>
To:     Moritz Fischer <mdf@kernel.org>
CC:     "trix@redhat.com" <trix@redhat.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Michal Simek <michals@xilinx.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>, git <git@xilinx.com>
Subject: RE: [PATCH 2/3] fpga: region: Add fpga-region property
 'power-domains'
Thread-Topic: [PATCH 2/3] fpga: region: Add fpga-region property
 'power-domains'
Thread-Index: AQHXJ6KbIboogT20lUe4ToWVY3OqHKqheFQAgAQlMfA=
Date:   Mon, 5 Apr 2021 08:46:51 +0000
Message-ID: <MWHPR02MB2623E90AF327BF4416D30729C2779@MWHPR02MB2623.namprd02.prod.outlook.com>
References: <20210402092049.479-1-nava.manne@xilinx.com>
 <20210402092049.479-3-nava.manne@xilinx.com> <YGdROrOOzltI/Bbe@epycbox.lan>
In-Reply-To: <YGdROrOOzltI/Bbe@epycbox.lan>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 80d636c0-d990-4310-81e6-08d8f80f5bd2
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2021 08:46:51.9996
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IvF1KVWJOSWp9sy3o3OzMNUBuS3o3cL1lotSsfbVJ4pJOR1T5TdXOB3zWLcgTMpZP1mTfNHtZNUbqPz7k8JjSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2255
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Moritz,

	Thanks for the response.
Please find my response inline.

> -----Original Message-----
> From: Moritz Fischer <mdf@kernel.org>
> Sent: Friday, April 2, 2021 10:46 PM
> To: Nava kishore Manne <navam@xilinx.com>
> Cc: mdf@kernel.org; trix@redhat.com; robh+dt@kernel.org; Michal Simek
> <michals@xilinx.com>; linux-fpga@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; git <git@xilinx.com>
> Subject: Re: [PATCH 2/3] fpga: region: Add fpga-region property 'power-
> domains'
>=20
> On Fri, Apr 02, 2021 at 02:50:48PM +0530, Nava kishore Manne wrote:
> > Add fpga-region property 'power-domains' to allow to handle the
> > FPGA/PL power domins.
> >
> > dt-bindings: fpga: Enable PM generic domain support
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > ---
> >  .../devicetree/bindings/fpga/fpga-region.txt       | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.txt
> > b/Documentation/devicetree/bindings/fpga/fpga-region.txt
> > index e811cf825019..969ca53bb65e 100644
> > --- a/Documentation/devicetree/bindings/fpga/fpga-region.txt
> > +++ b/Documentation/devicetree/bindings/fpga/fpga-region.txt
> > @@ -196,6 +196,20 @@ Optional properties:
> >  - config-complete-timeout-us : The maximum time in microseconds time
> for the
> >  	FPGA to go to operating mode after the region has been
> programmed.
> >  - child nodes : devices in the FPGA after programming.
> > +- power-domains : A phandle and PM domain specifier as defined by
> bindings of
> > +	the power controller specified by phandle.
> > +Example:
> > +	fpga_full: fpga-full {
> > +                compatible =3D "fpga-region";
> > +                fpga-mgr =3D <&zynqmp_pcap>;
> > +                #address-cells =3D <2>;
> > +                #size-cells =3D <2>;
> > +                ranges;
> > +                power-domains =3D <&zynqmp_firmware PL_PD>;
> > +        };
> > +
> > +	The PL_PD power domain will be turned on before loading the
> > +bitstream and turned off while removing/unloading the bitstream using
> overlays.
>=20
> Can multiple regions share a power-domain or is this specific to full fpg=
a
> reconfiguration?
>=20

These are generic changes and not limited to full region. If H/W supports i=
ndividual power domains to control the Partial reconfiguration regions we c=
an control the individual Partial reconfiguration region power domains as w=
ell.

Regards,
Navakishore.