Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3064170pxf; Mon, 5 Apr 2021 02:08:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPSLa2/Efve7PMXjsnbwA+XLtDR2QgiSORMEB4i/VPDfvPR9A+uMXWdLlHYUMGLX53fyEc X-Received: by 2002:a5d:8453:: with SMTP id w19mr19123196ior.25.1617613681034; Mon, 05 Apr 2021 02:08:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617613681; cv=none; d=google.com; s=arc-20160816; b=J5DukdNxhpnP9DCDJus90iIT7S8XkLTzazWTHc8tVkHebGNbkEIObKNuBkacBiUB7d CcPFxz0N4BwrAma3KXqPjej/aMP9Fg6fKIouelivWvjXxQOlTKZArGaxCP1APt+ZNsL8 uvd6FLsFsLFHPbQf+Ciykq3l4oYAWVZM8wu5QYaXz03kKzY9lweLaLuwdrjVpFXANV/m rYrrTObII1UG6Mnnc9olDuMCD5A8uiM45qFsNY6QaaFr5iXWTkz6Ap1Dbm2jmUEoi95t FZhZNfvcRjLnloLCLezNOr9q6TWJiwECgvLnEtz7bdy9uBwQsAZKAxJa4W3+W1O95yRJ xqbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MpdDC79HfhOX5EX3oqrzOZP1S1SfcIVsw+SbwD4LZP4=; b=jTienJLdDr13TE5akb5GYKcaqm12AhQDecB13yndHzKM+u8VbOWxd70CtLwOIs49XC HTAjXl+HVQuaV3pN77C+HrN9KiXU+0ShHFznIyWa4YsD2EFalyVI2sx/TQJ9Y88hCvDW 3TcCK1aFyRj79HZ9COj9wfu2gfuP2YwfUMRIBfSyKXCnz1q1ScIp3E2+fm7aibr8oBe/ 0dqwIJdF0+MH/1Yhp3YRIWFz9c9CV+BtHHMOj2bfAE3jrpeHUqL0eGLYo5q2z9dRody/ Itursr6aUVUvdOrtals3lANbYI6+Rbyf+jRbqzVUf/mUq5DiSG8xoxM9uStM7NwwiXdm 2AjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="D4HFG/5l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o19si13936564ilt.113.2021.04.05.02.07.48; Mon, 05 Apr 2021 02:08:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="D4HFG/5l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238331AbhDEJGy (ORCPT + 99 others); Mon, 5 Apr 2021 05:06:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:48370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238620AbhDEJFN (ORCPT ); Mon, 5 Apr 2021 05:05:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AD2E361394; Mon, 5 Apr 2021 09:05:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613508; bh=+FO1BZS3CrWpopcpgXL0cMFUmBp1NcyYyfIHiWj+oLU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D4HFG/5lmSZCaK3uT8/neFD+9VpmTtk9Vcq6rG7tpCQvdpvJxT1fhv0v2UtG0wXsS 363e1pDUX1lDM9SypYlVNTN6swy3h/aDkUUhS89XhvKLwIV3KJ/wxmlgUgRE6cO0rm u+HN8wLzGwuw3fj4qSlbVeu5CLG1r40KKIsi6CI4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum Subject: [PATCH 5.4 64/74] cdc-acm: fix BREAK rx code path adding necessary calls Date: Mon, 5 Apr 2021 10:54:28 +0200 Message-Id: <20210405085026.813676024@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085024.703004126@linuxfoundation.org> References: <20210405085024.703004126@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit 08dff274edda54310d6f1cf27b62fddf0f8d146e upstream. Counting break events is nice but we should actually report them to the tty layer. Fixes: 5a6a62bdb9257 ("cdc-acm: add TIOCMIWAIT") Signed-off-by: Oliver Neukum Link: https://lore.kernel.org/r/20210311133714.31881-1-oneukum@suse.com Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/usb/class/cdc-acm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -312,8 +312,10 @@ static void acm_process_notification(str acm->iocount.dsr++; if (difference & ACM_CTRL_DCD) acm->iocount.dcd++; - if (newctrl & ACM_CTRL_BRK) + if (newctrl & ACM_CTRL_BRK) { acm->iocount.brk++; + tty_insert_flip_char(&acm->port, 0, TTY_BREAK); + } if (newctrl & ACM_CTRL_RI) acm->iocount.rng++; if (newctrl & ACM_CTRL_FRAMING)