Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3064351pxf; Mon, 5 Apr 2021 02:08:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFl5R4pij4y/zQ2enQFxgTK6xf3vuZi5tSuQf9VbpO5UrSggIzbSMon6ws4GsDgMfttOB5 X-Received: by 2002:a05:6e02:1989:: with SMTP id g9mr18928507ilf.40.1617613701074; Mon, 05 Apr 2021 02:08:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617613701; cv=none; d=google.com; s=arc-20160816; b=KGeKKaRpZveiYls+T8uKAN5wGVWrT92u+UfiKrTqgocA2cWMeUl28Fh5Gwim0Z+qwH 3zaTfyK+Eag2um7jUcwCNZ5oavX2dWyoDnofgyV2BFfGtsOVvrz/QolYjBDAqLfubZyN u2ZegghJmmqWa0kMZSdIDF1jjg6DUp+cdxI//E61kMYAnbrIra1cM/UQ3XIVlbw2lal8 E0gBpvkZEet9jlZrKqp4dwPNfOKCQqdBOfd46MDmFS8uyK3b/qwQhi7vyJ6bszk7Xoq8 LuvDXglyol7TJag62j6ksaJw87zaQkdcDveNoTulTRg+jr9tHt/uyaTKhTKXQJ5BUGnE i8KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MGIN8FVwVh+uWMoH0pL9uQ+h3kNqQSZnVTLM1bEbl8k=; b=joDETth0TvDbbP17Pc0AwT4wiS8Lp7ZD/QdeDf5PDcGb6hBRaW2N6rD1FJsSNZfw3r RtzLu6mvx6xIQxrtP4ijQLOEpNJYimNhg6NeoN3kpHdQubDxPrlOf4K/EqFYwhfoykfR l9ym+yDFmm4B25Rox7S3zQ3I9oj51bDHhLEe6izHTFKCQHU5Bq+Joc/fOg4uyndCj/6D oNc3FTwlJ5TuufPWLz9Fa6s34loCUUac+qGVWfqhsOis8Bly4P+cINdUbEMLkTxpuS7N KexanOAnl3c5VHZKTf1TapC3KoaWpKjLI8plQYnjbSk4DkmjPvpgaZRC1D2GjHFm7HgK eMZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JS8PRx3S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e8si14573545ilc.89.2021.04.05.02.08.09; Mon, 05 Apr 2021 02:08:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JS8PRx3S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238289AbhDEJHQ (ORCPT + 99 others); Mon, 5 Apr 2021 05:07:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:48440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237515AbhDEJFT (ORCPT ); Mon, 5 Apr 2021 05:05:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4AB5F61393; Mon, 5 Apr 2021 09:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613513; bh=POI0oBaozY6U+hV989EtAESiFgx3Mca49k+f7ZRMob4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JS8PRx3Sn6PYXtkmKnkcdL8rKBuUJI6NmisCbfdyXrqxyLW1z3xGeW787AHCboiTN /CyiTu/naVMuH9vALX5jevl5jlik3wj/cTn6dq/qj1ZAfZ0OuBxZSXZkEnlMoy6K2e mHqS8xIjIZavCKOyoevXbEW39gjO7HBkHsYG8tec= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bruno Thomsen , Oliver Neukum Subject: [PATCH 5.4 66/74] USB: cdc-acm: downgrade message to debug Date: Mon, 5 Apr 2021 10:54:30 +0200 Message-Id: <20210405085026.882881754@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085024.703004126@linuxfoundation.org> References: <20210405085024.703004126@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit e4c77070ad45fc940af1d7fb1e637c349e848951 upstream. This failure is so common that logging an error here amounts to spamming log files. Reviewed-by: Bruno Thomsen Signed-off-by: Oliver Neukum Cc: stable Link: https://lore.kernel.org/r/20210311130126.15972-2-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/class/cdc-acm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -658,7 +658,8 @@ static void acm_port_dtr_rts(struct tty_ res = acm_set_control(acm, val); if (res && (acm->ctrl_caps & USB_CDC_CAP_LINE)) - dev_err(&acm->control->dev, "failed to set dtr/rts\n"); + /* This is broken in too many devices to spam the logs */ + dev_dbg(&acm->control->dev, "failed to set dtr/rts\n"); } static int acm_port_activate(struct tty_port *port, struct tty_struct *tty)