Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3082615pxf; Mon, 5 Apr 2021 02:44:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVWpt79B4jaKXtKLOnHSg2NFB+DejEziObNqLyqsUu6hbsnow2siqRheb8KqGS9FfA5BQO X-Received: by 2002:a5e:8d01:: with SMTP id m1mr18763068ioj.72.1617615884769; Mon, 05 Apr 2021 02:44:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617615884; cv=none; d=google.com; s=arc-20160816; b=z/ifGRg3Lqx4bypyb0QjCJOhlAZQ8QkqSpym7cfsD8dMyeXiv6fgPwhhwxt3lnIO/t Ezw1z0v4IOpkg1Jst6Mp3V2W+ugkH3naLVZQMdZHFUz5xBh/D53gkTZxOXQIop0veBuf sr0umThc26OcIXRyR+bBSUfzZU7PU0QiszKjrxpNsYABqAwT1zVVkv/pVMHj1r4y0vW5 n8YKgjEl8vUen6q/SALVN4j3W4QDXkIIkGTHsoNVkwTtqOr5MslEaB/NTH6tyWMquCJs TajBxg8TG3OOIrgMv2LBavS/S92SfLirQzS22cxrywSWjb703kJw+lnyHfQWUVk89vll Avhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AyLM2WFaTPv3++kElPu6yQOXpHl13tqxkR4SXM4fUdo=; b=kBf5ged+pnnE+N53xdXLuyxX1/qjlPvO3cMtGKLNLPKlSR6pHZoDBV1TzEnhaZ72Hy jD1SygoNm1RiVsVGTgbQAsu3jGNVbTbApSHI3+tYTSTQ1MHrLS3+Gvam6m+8x9DnReXX VB1DyPxqo7BueM7XvjuygthouxqtXX6AmnsOLcU6ky7t0Ino6PeqbCRuXUAl7qPybkHi dAVOg2XaYjxgM9eWkVF8ws8mpAr2WX+bhYM29XAp4VSHRlmxbJ+V14Dnlh5nPHNEGxCE tZsOoyfwlZLZGWEh3q0AAVvlMhebsJ+UMXfhdsQtpKZFWYu4tje8QPLCtDS7Di+w6Loh V8tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aln2MlR3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z3si15745177jan.94.2021.04.05.02.44.32; Mon, 05 Apr 2021 02:44:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aln2MlR3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232499AbhDEIbj (ORCPT + 99 others); Mon, 5 Apr 2021 04:31:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:50556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232494AbhDEIbh (ORCPT ); Mon, 5 Apr 2021 04:31:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A0556138A; Mon, 5 Apr 2021 08:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617611491; bh=4h+3V9BjLvedrsA7WoinA5RtgLJESAo1x/zGN78m6w8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aln2MlR32CE3jYHBOtdofAc6y6FPQk2w2FWjPg2YQMOZ0ESH3lseWv1CN7EW3taRK wOfLtJbPPs0pfPBiQME579aTAUAv2jCPAiDpfbSZmIDJaP0wOo1GD7LCnSHlsInxxu L8+0jg94uinFclmeiTlHi6S0c7Vw0eX7kAz/mVI4= Date: Mon, 5 Apr 2021 10:31:29 +0200 From: Greg Kroah-Hartman To: Ahmad Fatoum Cc: "Rafael J. Wysocki" , kernel@pengutronix.de, Andrzej Hajda , Andy Shevchenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] driver core: add helper for deferred probe reason setting Message-ID: References: <20210323153714.25120-1-a.fatoum@pengutronix.de> <20210323153714.25120-2-a.fatoum@pengutronix.de> <55ed4f2d-70f6-9ee0-731c-8a7b3a379aa0@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55ed4f2d-70f6-9ee0-731c-8a7b3a379aa0@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 05, 2021 at 10:27:56AM +0200, Ahmad Fatoum wrote: > Hello Greg, > > On 23.03.21 16:37, Ahmad Fatoum wrote: > > We now have three places within the same file doing the same operation > > of freeing this pointer and setting it anew. A helper makes this > > arguably easier to read, so add one. > > > > Reviewed-by: Andy Shevchenko > > Reviewed-by: Andrzej Hajda > > Signed-off-by: Ahmad Fatoum > > are there still objections to this patch? > Patch 1 was applied, should I resend without? No, I'll queue this up now, I wanted patch 1 to show up in my "next" branch first, it's now there, give me a chance to catch up on patches... thanks, greg k-h