Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3246090pxf; Mon, 5 Apr 2021 07:09:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznMyBhUP4T7s71kOpx53/kBPycNj1TINPS7iMKXkDz7bhWyoeUaTnFwsvu4vYr5X4NPFHm X-Received: by 2002:a05:6e02:1546:: with SMTP id j6mr2901798ilu.299.1617631772374; Mon, 05 Apr 2021 07:09:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617631772; cv=none; d=google.com; s=arc-20160816; b=UDsWX/qm1Y441BbkTTjzjxH6ylw9hfdqgMQHYrz0KJPZIsYn0HIkI4q+uVN3wGxBO3 bLDtOact8QWzv/eWqO5d3FeJZ5n8CefrdBYenwzm41Up722T8yAmvzik1IjQ6B+sfdLo jgI6Na8hQLax2bdokGiVGlG5dAV2DXia/tcgN5Ug3RdShVCkzIBBtzm9pP6Tdo+4LgKz Czdr6fM8rjKu4rOAETUv2xLTq12/k4wHPo2IPu/QIPzsYE/r2rzoc3Mwlob+mpmCBLsU 47Nm/BHwllZXKhD98vU29mflJp46RHYlWSb6EsFkJhaMB6v6RPMqUOQTF7z7/Sw4fUee m4zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fPdpxSc3P7+wUOwyzZuHIfZA6gMwmkzFaCTkNOBYQLs=; b=uNuyIaBjhpiEP8f7DTLFVEZyMRqQNb4aZnYzkWNfQnAamjZvjBGURJQMkcc7zGx/xO 0QjBO9fJWeDVo16ywf7/bZUJa8Z/HuuZ0xOaLMwntphUJTcqmBGyAYhwioPTnd1oQGFt f6JADqkV/NCaFENZ0YynOR76ULmr7dQC9bfb+N/NeNbA9F9HetenTst2qOYDLe22pLbt IQTtxp0QWgIdppBiMsjrhBEeOhH5tDedouKtRIy4xm2Kf/3k8yraObCOGCPsjvB6cv2o 95WKPTK40PvB2OeFHk5kdhDsVWdmz1XCRjsX5KeHln9zEgLgcRvOmrfZ7N/neek/9/3c N/Tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mmfz2Gpp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o7si17050055ilt.153.2021.04.05.07.09.19; Mon, 05 Apr 2021 07:09:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mmfz2Gpp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237568AbhDEJDG (ORCPT + 99 others); Mon, 5 Apr 2021 05:03:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:43758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237287AbhDEJB5 (ORCPT ); Mon, 5 Apr 2021 05:01:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CFD89613A0; Mon, 5 Apr 2021 09:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613281; bh=g0qZpeSPtzZVibiraWCZWalUtxFApgC2P7j26wf8bcM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mmfz2GppDmDlt2EzdLUZ6t+UBCZik0VX+88ilkcrxUxyt4CrEGGnLpq6wz+2V0fvr kqpdPbdMxQIDf0es/J30Pa7zas0N0aZkyEjTBxCOoiGFTBn8g/re9FEqumTfWSpACC dFMNf4M13ElFfNo0DOqVlo8WS87UHd+4Yz1YVAT0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nirmoy Das , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher Subject: [PATCH 4.19 36/56] drm/amdgpu: fix offset calculation in amdgpu_vm_bo_clear_mappings() Date: Mon, 5 Apr 2021 10:54:07 +0200 Message-Id: <20210405085023.687164208@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085022.562176619@linuxfoundation.org> References: <20210405085022.562176619@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nirmoy Das commit 5e61b84f9d3ddfba73091f9fbc940caae1c9eb22 upstream. Offset calculation wasn't correct as start addresses are in pfn not in bytes. CC: stable@vger.kernel.org Signed-off-by: Nirmoy Das Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -2286,7 +2286,7 @@ int amdgpu_vm_bo_clear_mappings(struct a after->start = eaddr + 1; after->last = tmp->last; after->offset = tmp->offset; - after->offset += after->start - tmp->start; + after->offset += (after->start - tmp->start) << PAGE_SHIFT; after->flags = tmp->flags; after->bo_va = tmp->bo_va; list_add(&after->list, &tmp->bo_va->invalids);