Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3261807pxf; Mon, 5 Apr 2021 07:31:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxUbNMu+D10sRQUf3PA1Tr3W7GnlGvqMvM+Ro8H4xgGPvTZAZDYjiJme8dcWsoY2tcE8PN X-Received: by 2002:a17:907:629e:: with SMTP id nd30mr28375604ejc.407.1617633107932; Mon, 05 Apr 2021 07:31:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617633107; cv=none; d=google.com; s=arc-20160816; b=PZ4wBr7vZtOVO69Mk6davDxnmNThYXKnJFQfF0L0aoGpnbdmhcow+wEngZBHh9ASkx f7/aBJf03SPjq24ZT58g3B48/eCcCiTYgGIVSAjL1sH0U6DJkBkATuA2ly2hz+auhhTn L1eSAFhPtm7CrFYQMwXqlpEDmWKa0M/pbyjn950/kogyzkmJ79vwSbTFN2hDQynexZ+0 deK4h3Wh0StVqhY15ZEPBr81EK8qjm5HGnVNWXH8cDDDhAQtXszrpZuk0b5SRpnKVmvM /gFxc45Z6tdYr80Q0cQBudsE1c6a9Jgl0dAUMTTIZYVURocpk4wreqscDlPlYX6PS/+/ nidg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MpdDC79HfhOX5EX3oqrzOZP1S1SfcIVsw+SbwD4LZP4=; b=z7Uys71mnEg0qWHtMB8Hc3YM7YbNViqXQEWSDkAWaBGbBgc1rbusO5h8qZe0f/SRjp iuANxGO31ASdrPel/ah7Y0O2v1UDj9exRidYIC1n+z+2bxaiClNM19/AEd2RoJaFmahj ijUu36Sm7Q3mQMf74o07q81t8FBweiOaR9IYhXehJsDOW4EtHtoOcnYRLCsd+FDOahOv 5WLQOrbpJI/EYtU8cmeXca6nbUzp8vderzNK4pbz2cGwaoHTm80cC/nv0j0TEt/p2v0y acPsEZOEFgyJ9ZxjNy+mmaP++QZcSDKDX5D3yLPtU01LJvZfbbyr2g1ye7LJbWfwtFao XNRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ZS+Lil/1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jx25si12985952ejc.382.2021.04.05.07.31.23; Mon, 05 Apr 2021 07:31:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ZS+Lil/1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237695AbhDEJDe (ORCPT + 99 others); Mon, 5 Apr 2021 05:03:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:43946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237355AbhDEJCJ (ORCPT ); Mon, 5 Apr 2021 05:02:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B03836138A; Mon, 5 Apr 2021 09:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613314; bh=+FO1BZS3CrWpopcpgXL0cMFUmBp1NcyYyfIHiWj+oLU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZS+Lil/1T+a7R/boeFbc3Q6tr6qCBAbwQVnXK81/B3yf3iEF+lIB2eAblrKV4BRb1 9LMjP6bvTiFiI7IsEC9BcMWTgb1ufMNeu8LjQMohDAUoT/OlKYLjj3UzO3oSfPfdou OKtw1jbFm7U+YT7Y4Xp5U+aY2B/oBCKmV3qjkABQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum Subject: [PATCH 4.19 47/56] cdc-acm: fix BREAK rx code path adding necessary calls Date: Mon, 5 Apr 2021 10:54:18 +0200 Message-Id: <20210405085024.029250827@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085022.562176619@linuxfoundation.org> References: <20210405085022.562176619@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit 08dff274edda54310d6f1cf27b62fddf0f8d146e upstream. Counting break events is nice but we should actually report them to the tty layer. Fixes: 5a6a62bdb9257 ("cdc-acm: add TIOCMIWAIT") Signed-off-by: Oliver Neukum Link: https://lore.kernel.org/r/20210311133714.31881-1-oneukum@suse.com Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/usb/class/cdc-acm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -312,8 +312,10 @@ static void acm_process_notification(str acm->iocount.dsr++; if (difference & ACM_CTRL_DCD) acm->iocount.dcd++; - if (newctrl & ACM_CTRL_BRK) + if (newctrl & ACM_CTRL_BRK) { acm->iocount.brk++; + tty_insert_flip_char(&acm->port, 0, TTY_BREAK); + } if (newctrl & ACM_CTRL_RI) acm->iocount.rng++; if (newctrl & ACM_CTRL_FRAMING)