Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3265303pxf; Mon, 5 Apr 2021 07:37:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXpBy3AoV6cV8twNRAfMpcBV7wThoXQ2tRHCwcdmzbeFFvcUyfbrEbnO4kW6SnkHh7+drm X-Received: by 2002:a17:907:1184:: with SMTP id uz4mr5315167ejb.465.1617633422347; Mon, 05 Apr 2021 07:37:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617633422; cv=none; d=google.com; s=arc-20160816; b=enMj0VG5siI4chlACuUpwR60hhOIj3g60Mb00p0piOspIOGbvN2WSWxU0vyjurAzA9 a+jn8u2WD70CaKEgq+AviN8BCI1QaavMFAk7tnaBT5I7iz+mL4wd2pkedJeEgdGE/QUa /+DlPXeb+SEt/sBWMOJ/zfeogVQAAYVruErEREJnpxTQTYDtvQLYhAptdK8haAcvW/xe v3U9/fxWo+0ac1I6XOt6JRGl1GJZI1xuAZYfAER6JaK8ghpvaUtRYbJ30n1EGhmh/E2M jqErfB6ukB7r4aNAJ1HlIeRFY9odn+1YVw7GlIzNhlotUxlrgTDuEWZdHc77b/IXp95J Iyvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7ZsfruYTwSR8RN5Kj8wlwCCMimnbYc01sMPoKsszd58=; b=VX3zcoJRXukAkTLXqsNKI0bWiPSBG3QTEwevkFDQlyeNdO8OQ6Fzkzv8TFoSrv7HG4 J8jg/fJIOZi8O4OQ8LJg6e/QznazW4UUqd19Q0X55mxB4SJZwPJP/cApmCYYouQHcyLC Mm5qzHwL4my6ChngIhZk/dK3RJdTsxMh/ypfplXhPwDkyPNQGmRgFcnSIDFgt5lWbLPJ NR4iIqdNKGTvGjK21g4ZWcjF8O5MePKdTmjd4sbX1EGMdqoHOHOR/otFgj1Hky6eG8Ea V3k9Gz4eNtJnM/nsUJa/C1fJ26KiBsaaLqt1hpL8mMuQ+6SqHy+0COOUuPR6C2574TG/ JUoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XGpqZkE6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bl5si13377334ejb.232.2021.04.05.07.36.39; Mon, 05 Apr 2021 07:37:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XGpqZkE6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237782AbhDEJD4 (ORCPT + 99 others); Mon, 5 Apr 2021 05:03:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:44694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234042AbhDEJC1 (ORCPT ); Mon, 5 Apr 2021 05:02:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 10B7961398; Mon, 5 Apr 2021 09:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613341; bh=obCiCmiLX52EqECMhvJW2zefwKWGKetq7U6QD6JtWQI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XGpqZkE6NdMGjwoeX4EPoXWlRwjgEp/4Pm12vif31N0y3w7XRD5cyC6JgdjvKtjfF 3BDZFvlwT588dowd3stOmeefSnpTXsaLa0elT/huTaG3djLtHthjcpgho+GwHgTm9o TX13C49uwFUQ7lyBVOmF1IjBUXCrOqRHiM/fpyaM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+b67aaae8d3a927f68d20@syzkaller.appspotmail.com, Du Cheng Subject: [PATCH 4.19 56/56] drivers: video: fbcon: fix NULL dereference in fbcon_cursor() Date: Mon, 5 Apr 2021 10:54:27 +0200 Message-Id: <20210405085024.311723488@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085022.562176619@linuxfoundation.org> References: <20210405085022.562176619@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Du Cheng commit 01faae5193d6190b7b3aa93dae43f514e866d652 upstream. add null-check on function pointer before dereference on ops->cursor Reported-by: syzbot+b67aaae8d3a927f68d20@syzkaller.appspotmail.com Cc: stable Signed-off-by: Du Cheng Link: https://lore.kernel.org/r/20210312081421.452405-1-ducheng2@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/core/fbcon.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -1306,6 +1306,9 @@ static void fbcon_cursor(struct vc_data ops->cursor_flash = (mode == CM_ERASE) ? 0 : 1; + if (!ops->cursor) + return; + ops->cursor(vc, info, mode, get_color(vc, info, c, 1), get_color(vc, info, c, 0)); }