Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030404AbWJKOUM (ORCPT ); Wed, 11 Oct 2006 10:20:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030406AbWJKOUM (ORCPT ); Wed, 11 Oct 2006 10:20:12 -0400 Received: from 85.8.24.16.se.wasadata.net ([85.8.24.16]:17808 "EHLO smtp.drzeus.cx") by vger.kernel.org with ESMTP id S1030404AbWJKOUK (ORCPT ); Wed, 11 Oct 2006 10:20:10 -0400 Message-ID: <452CFD98.6010808@drzeus.cx> Date: Wed, 11 Oct 2006 16:20:08 +0200 From: Pierre Ossman User-Agent: Thunderbird 1.5.0.7 (X11/20061004) MIME-Version: 1.0 To: Matthew Wilcox CC: Arjan van de Ven , Amol Lad , kernel Janitors , linux kernel Subject: Re: most users of msleep_interruptible are broken References: <1160570743.19143.307.camel@amol.verismonetworks.com> <1160571491.3000.372.camel@laptopd505.fenrus.org> <20061011141651.GD27388@parisc-linux.org> In-Reply-To: <20061011141651.GD27388@parisc-linux.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 536 Lines: 18 Matthew Wilcox wrote: > > They clearly don't care about exactness; they msleep_interruptible and > throw away the return value, so they don't know how long they slept > before they got a signal. > It's broken then. That delay function should delay at least the amount given. Rgds Pierre - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/