Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3294589pxf; Mon, 5 Apr 2021 08:19:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQ/lEHEyBXN2tj/d0k5PlMimk4KANtTIkCgE+qoDvyvN4tdPulDk0AGlvvHYTz1Ct8YC1K X-Received: by 2002:a92:c847:: with SMTP id b7mr118763ilq.131.1617635967541; Mon, 05 Apr 2021 08:19:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617635967; cv=none; d=google.com; s=arc-20160816; b=AJTThy+EXLr6FXlgXT0vNdwBsfinv89U8hO4AZZ2iImFFETU7VsbZLhKcsTVTIQWCi eU2ILSRY8Ribmzb2XrgrlqHb5UarTU8bKmmzwOswGZBl54xscOLCer2R8vu8w/GuCCpK GtWvGe9JATQpXH1igtQDayTY4Wr0IK6a0MwwURnfWIKg5V0XqHZmKv1ZpaFsygGi4Hxq LZ2cKr5K34dnLcC07J98To1xDYArcScUi2Kb+5ykd7el9lJV2hvMNIbcHxu0mvk1bkk1 3s+PE8+Qb34/WliEe5oiad1JvRXqtZifn7/j4tc5gHQbXS4HeLlK9/n6rSToqtKsAqwu 0RLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tsNy2Poww16/komGPQE2itezokFLg6hKK335r7ovTfE=; b=fOQ7PJw9tTwCJj2QsQ2LXlhkXlscGM2/axf03gjgKiy9hpKwg+sSL8RkbAR3EQdxqQ cDm6+fDKHHvxV01QmcveMobIowPo29tXMBNeNZ8yFSaF/vfCQF1ghJVkiUdcS55tRHe0 1njMEa+ba45vmOwKekGGCmRXlz6h6/yG1x4uZFC1ADYYBxie2D5HQsPWSQfmXTLxXnYO 093MUjPK2mdscBmGbHJLqXs4tzRmB5uDY3UtBSNFFISYUd1jTSCHwtSuO0LnKw1MkbMj /UDvJizo43pfYdLcVaEwA7wiY6DthNUQj8ufj3vos0+IaKsK5gQzGfLPyZ8Zl3n+6Zhd ZMTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ox80Jo6s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a17si15900225jat.53.2021.04.05.08.19.15; Mon, 05 Apr 2021 08:19:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ox80Jo6s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238158AbhDEJHF (ORCPT + 99 others); Mon, 5 Apr 2021 05:07:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:47924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238079AbhDEJEX (ORCPT ); Mon, 5 Apr 2021 05:04:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3230761393; Mon, 5 Apr 2021 09:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613456; bh=I/nAkjDaD7yeDiDFFpL/akotLAltLpbJ16vuDw93Gi8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ox80Jo6sFsfdOmIhcw9YBrkX6QdG/Bn7g+rXtYTR2tIXyBUeY9kKrcDgFmhJX8hUM gi172rW08jLTU/M7zMBqfAEVs5FisUgcjUCFjUXy1RUV+ZnTZXgP0kHytelOc+FEbi i+BsA+/oHxDykh9CqqTCMU53sw5Xi6bGK/UTT+kc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai Subject: [PATCH 5.4 42/74] ALSA: hda: Re-add dropped snd_poewr_change_state() calls Date: Mon, 5 Apr 2021 10:54:06 +0200 Message-Id: <20210405085026.098032720@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085024.703004126@linuxfoundation.org> References: <20210405085024.703004126@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai commit c8f79808cd8eb5bc8d14de129bd6d586d3fce0aa upstream. The card power state change via snd_power_change_state() at the system suspend/resume seems dropped mistakenly during the PM code rewrite. The card power state doesn't play much role nowadays but it's still referred in a few places such as the HDMI codec driver. This patch restores them, but in a more appropriate place now in the prepare and complete callbacks. Fixes: f5dac54d9d93 ("ALSA: hda: Separate runtime and system suspend") Cc: Link: https://lore.kernel.org/r/20210329113059.25035-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1024,6 +1024,7 @@ static int azx_prepare(struct device *de chip = card->private_data; chip->pm_prepared = 1; + snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); flush_work(&azx_bus(chip)->unsol_work); @@ -1039,6 +1040,7 @@ static void azx_complete(struct device * struct azx *chip; chip = card->private_data; + snd_power_change_state(card, SNDRV_CTL_POWER_D0); chip->pm_prepared = 0; }