Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3295185pxf; Mon, 5 Apr 2021 08:20:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqcQOaDkXU6AscElkzVJjebk0cMXYoKNdG51ukdWAysv74dJdBBH9d6TfRop4Kh+kPFyaP X-Received: by 2002:a05:6e02:1a0a:: with SMTP id s10mr10595319ild.154.1617636018196; Mon, 05 Apr 2021 08:20:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617636018; cv=none; d=google.com; s=arc-20160816; b=AXsOz96QRUgBLdNUqpVyUgKCnrdZZPQNzm08ViV9ceo6H+/fQPy397QRvRRc+vWcdC fbZ0Lp0mUKWCLs2RAsrW3yzsqSd7Yqaw8DWk/H5ZOoXsyvzqIB+7TkDsRRDka6o/jNOP fKHX9adgB6KPab3Scws2IEK2vXwjl/qyEH4xfMhca4Ca9jOHoEW2TMSqis3GN9WiSz7B l7XYksby5XBcquqltZ4LILAVtuGfa0Ia5p9DNVrMqAezYiIvCeXWyzzo1bcQ/Yj/vFUv QA5ziT1YjWflYkBr910DxUlApiYMBDWST4IGpjLhmQ/iq+uwe8yZ7fAatY8vYYdGmPSe HIMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YK9kfWnfHTgcCvh0/vjW0icKyqPAaoaYjas5yQjDPgM=; b=fsl/tp3snRrtuSPtn4t00eYAJuVQ8MRFsXPoPXykfta7N21tDNrzLZw1euyTbZXOQI uz1sNcxP1qcovbgJWVsp8lo5Wb4t5TgyzVELTFPwJXq7Up5aXwiRc2FZsdti6IZK/gGg Of5OKS9nGaFdeZ9MIKbBBBNqOq+uOD9mdaE+/XKxpib0DWc85tM0CSp1B8izP2oV6Ppj 0OY17RTkB8g5OuRPsk3Z+D8W+E3d6fRrxAlqC6aowUTXko2lm7l2qyhaLZgWgxoA4Set 3hH4A7IEcNRYlwwLeuXj+XFgeraPkojQ2JNJkqZc+uDa4rovD2EOXbBa25DluUojH3z2 065w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ha4py1si; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z6si15658745ilb.14.2021.04.05.08.20.05; Mon, 05 Apr 2021 08:20:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ha4py1si; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238451AbhDEJHo (ORCPT + 99 others); Mon, 5 Apr 2021 05:07:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:49980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238654AbhDEJFp (ORCPT ); Mon, 5 Apr 2021 05:05:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 58CF6613A7; Mon, 5 Apr 2021 09:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613538; bh=pEzju/dlC2eXW2eScCWdr+GsuWS3ibxQw6GHftvlrlE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ha4py1siEOtxHPbxh+1U+SjabVrSqrbm2L6686Do7xo8t7aWGaxsr6EciPProsdEk EQqs9BQY3DMEqGiuJc87nwch+7sHHtNlru6q8gxLiSyFF8GCWZa2sCW4ApAb580NRE SuNQ9sIN+pgsPZbTdz/5uLmDDmirPaGdm4W4rCho= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+b67aaae8d3a927f68d20@syzkaller.appspotmail.com, Du Cheng Subject: [PATCH 5.4 74/74] drivers: video: fbcon: fix NULL dereference in fbcon_cursor() Date: Mon, 5 Apr 2021 10:54:38 +0200 Message-Id: <20210405085027.153874789@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085024.703004126@linuxfoundation.org> References: <20210405085024.703004126@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Du Cheng commit 01faae5193d6190b7b3aa93dae43f514e866d652 upstream. add null-check on function pointer before dereference on ops->cursor Reported-by: syzbot+b67aaae8d3a927f68d20@syzkaller.appspotmail.com Cc: stable Signed-off-by: Du Cheng Link: https://lore.kernel.org/r/20210312081421.452405-1-ducheng2@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/core/fbcon.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -1339,6 +1339,9 @@ static void fbcon_cursor(struct vc_data ops->cursor_flash = (mode == CM_ERASE) ? 0 : 1; + if (!ops->cursor) + return; + ops->cursor(vc, info, mode, get_color(vc, info, c, 1), get_color(vc, info, c, 0)); }