Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3295206pxf; Mon, 5 Apr 2021 08:20:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUDs3hXLhFAxtLvMEocx3EGOL6NLCwhxWQSw7bjsG3ZG1zPdp68ivbU0P04s7jaUOkBd65 X-Received: by 2002:a05:6638:635:: with SMTP id h21mr23748412jar.97.1617636020019; Mon, 05 Apr 2021 08:20:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617636020; cv=none; d=google.com; s=arc-20160816; b=vpHZLdVCI04mP47CNe7kdQKSNnUglk75xNFCgOd3XuxzSnw67UBczauyFVZ9xPqbHW ruXkhELUJuhSqNGobG+kzEU38GMoWroEZtkdQWQ6QLIQtyiNiYm4nBgywtsZAYIEJECY gP93Pd7iZ+OwPyTE0lseFS0Z3XvJBDY9nuHsZm0udZxodH7vyxKzU5jq6xaINuz5a4WV FFYKzYpoiaS3tP5r+shTj7vqUrur5V7YKrImmBWTwTt0IvOnv4QpThp1kX1KBEsiv8nk d5qvufleRsVCDMP3wpuu2Kd4A20lTMEFdYt3qW/8mpx0X5R/yApEojNpC3xEtahffKCR eZ0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QNubkE/+lLpQIl0yzwbt/+oi9vkhWNfH0QuKD4D6nzc=; b=iN82ZBN6edyk8ryCVeOVPtyezVpsS2JB0RT59KQkpGo+vMZF4JNXBC64LpKFWeb9Sl qDZ/nUBpsrabBtoKlFKN/PpcTRAKAq872a+c8b2RFKQKoFyShqOEpara4hRT8OSonnMO K+VvqTYV3yZhL4a7YL9ZhhhMTdqn9ZGxQCfj8NVtZoGb0L+DkJJ/KyUbtngAmtZ+JuYo 12uI6FmPJ/RSks5jcMT5xbaXTh5RG90bPx28dx2QdLP6fwGbwHfPRZqVNy7gXQoL9Hcn RgU0nb9kVzXXJ14sLxIex7OMemJ5268GHMZ8QPAL4OepYFlbbrfaZh8XpspYgM73gXN4 459w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Gpi5r0K7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n10si14681090ili.79.2021.04.05.08.20.06; Mon, 05 Apr 2021 08:20:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Gpi5r0K7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238309AbhDEJHs (ORCPT + 99 others); Mon, 5 Apr 2021 05:07:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:50180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238115AbhDEJFs (ORCPT ); Mon, 5 Apr 2021 05:05:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A866B613BE; Mon, 5 Apr 2021 09:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613543; bh=xbo72rp0StcXzPxBRlp6xb2F4oZ1gPDBq2qj4NMwwpc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gpi5r0K7UXe8P6VNuzGHU5z3lotB3zaI/lg0A3dEQh0dhOUktB6xPgQ6tAQJmTpQf 6lxF0qSn+Gbn0ZMxs7SR3ICt3mXthv0zYr29ZEo/wxl1C6M0GcHHQQwVSpJSe6uqZ3 Xuxq28rzLY/T7oUP1+Qj30auSG/CJT8fmA5rd89Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nirmoy Das , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher Subject: [PATCH 5.4 51/74] drm/amdgpu: fix offset calculation in amdgpu_vm_bo_clear_mappings() Date: Mon, 5 Apr 2021 10:54:15 +0200 Message-Id: <20210405085026.395311639@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085024.703004126@linuxfoundation.org> References: <20210405085024.703004126@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nirmoy Das commit 5e61b84f9d3ddfba73091f9fbc940caae1c9eb22 upstream. Offset calculation wasn't correct as start addresses are in pfn not in bytes. CC: stable@vger.kernel.org Signed-off-by: Nirmoy Das Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -2333,7 +2333,7 @@ int amdgpu_vm_bo_clear_mappings(struct a after->start = eaddr + 1; after->last = tmp->last; after->offset = tmp->offset; - after->offset += after->start - tmp->start; + after->offset += (after->start - tmp->start) << PAGE_SHIFT; after->flags = tmp->flags; after->bo_va = tmp->bo_va; list_add(&after->list, &tmp->bo_va->invalids);