Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3308446pxf; Mon, 5 Apr 2021 08:39:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFLWUTWcbRjkOai9hJrKYIL5zMJKwsDu+N8fBN5azGeQkvonrX2GNrBfik/v6w8QrI1s3J X-Received: by 2002:a17:907:2168:: with SMTP id rl8mr6891317ejb.224.1617637154710; Mon, 05 Apr 2021 08:39:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617637154; cv=none; d=google.com; s=arc-20160816; b=vn7ITBQ/tqGm/YSIYHgAZgPRz7jBnLScP3PomdwlAkoxBqHB9G9UxeuFeSufIefLVF kDsKS+lUILtP0x79dONVt8+xh1XPU5tFtafUsuiTBlyIbIRWq7x48IM/6GEWmMn/SzDH REfDWQTWCBi7JyG9Gw+95qb461CK/wJi1LEZ+EtaF6yJUatqOVwKbQNipxDx6Seya515 KT7y46AZ5+SuI0gMS4uCUA3bDDvmakts8otVATpvuwW56e76sAJOIcQsxus4k1gc4cc6 +vPD5mFK4rjGBcaVjsBMk//EGo/X1iD6Sen2Cw4y5POH23bt7nAj5T4OEw8x0JP0XijQ jH3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mscHbMVJXzxt2ZcNW2EyL/m5srAdH0mf9pO2OPFEu1Y=; b=Yi0zHibsNOVHUSKIL7cPLF6cOFhCcEsKSk62R59Lr6VL4UlQwiDGKiT7C4UmdRTG9H AwIjbbFWemdNc7plSoRxeu+6VCfXS66Mvv2ZhOaz3CxGMDCNokFeGHqJvQalh1pOZaNf Q2gQAUg9pdFPV3a6VgJXAmwKGLJpiiFavIQHfKjrt4+gu0sFI8BP7/Q0BkzzKcId2S6n gXydt20WPj3/1wU7Oj5ot1WX4Svm4C+b6IdXWR8xCQpFEhkyqJKvJzAUFwvcVaKVkBtd +92S7N3NqER40zQ39geyN20zq89g3vv57O4Tk/xMzxoTEnT9DYQ2ZX6ZQXiqAu9F2dT/ InQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sXpKmcoy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si14044188edu.114.2021.04.05.08.38.51; Mon, 05 Apr 2021 08:39:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sXpKmcoy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238001AbhDEJG1 (ORCPT + 99 others); Mon, 5 Apr 2021 05:06:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:48144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238336AbhDEJEs (ORCPT ); Mon, 5 Apr 2021 05:04:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3078A6138D; Mon, 5 Apr 2021 09:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613481; bh=hTaUs/AFJ1IfhtHqzUxdrQe0xhEMM47KW9UwRqj7Lo8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sXpKmcoyB8BY7xUMTeuscS1iJEBviBg/aXOH/SD58w1uXLy1bjVV1ZDcke8pMIz0S /M/MmMhuOJVbGsNXv8zJ3sso+Rr8YWxcjFeXceJojGwDsKmLYkY3cSz9NaxTVdm1mi 6WGH1MJWguuW8zHzDo9nLxNrZ9x7I+gIKxD0ZEHM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lucas Tanure , Mark Brown , Sasha Levin Subject: [PATCH 5.4 18/74] ASoC: cs42l42: Always wait at least 3ms after reset Date: Mon, 5 Apr 2021 10:53:42 +0200 Message-Id: <20210405085025.313530931@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085024.703004126@linuxfoundation.org> References: <20210405085024.703004126@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lucas Tanure [ Upstream commit 19325cfea04446bc79b36bffd4978af15f46a00e ] This delay is part of the power-up sequence defined in the datasheet. A runtime_resume is a power-up so must also include the delay. Signed-off-by: Lucas Tanure Link: https://lore.kernel.org/r/20210305173442.195740-6-tanureal@opensource.cirrus.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/cs42l42.c | 3 ++- sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 95930018a1a4..dcd2acb2c3ce 100644 --- a/sound/soc/codecs/cs42l42.c +++ b/sound/soc/codecs/cs42l42.c @@ -1796,7 +1796,7 @@ static int cs42l42_i2c_probe(struct i2c_client *i2c_client, dev_dbg(&i2c_client->dev, "Found reset GPIO\n"); gpiod_set_value_cansleep(cs42l42->reset_gpio, 1); } - mdelay(3); + usleep_range(CS42L42_BOOT_TIME_US, CS42L42_BOOT_TIME_US * 2); /* Request IRQ */ ret = devm_request_threaded_irq(&i2c_client->dev, @@ -1921,6 +1921,7 @@ static int cs42l42_runtime_resume(struct device *dev) } gpiod_set_value_cansleep(cs42l42->reset_gpio, 1); + usleep_range(CS42L42_BOOT_TIME_US, CS42L42_BOOT_TIME_US * 2); regcache_cache_only(cs42l42->regmap, false); regcache_sync(cs42l42->regmap); diff --git a/sound/soc/codecs/cs42l42.h b/sound/soc/codecs/cs42l42.h index 9b017b76828a..866d7c873e3c 100644 --- a/sound/soc/codecs/cs42l42.h +++ b/sound/soc/codecs/cs42l42.h @@ -740,6 +740,7 @@ #define CS42L42_FRAC2_VAL(val) (((val) & 0xff0000) >> 16) #define CS42L42_NUM_SUPPLIES 5 +#define CS42L42_BOOT_TIME_US 3000 static const char *const cs42l42_supply_names[CS42L42_NUM_SUPPLIES] = { "VA", -- 2.30.1