Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3316849pxf; Mon, 5 Apr 2021 08:53:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrVglkRclnU6RGip0Bxqwh/SVHLs5h98XFLzDxKMcJc2VNjz3J5GX9WhI+IuusnYZ498+s X-Received: by 2002:a92:c56f:: with SMTP id b15mr19683322ilj.41.1617637983794; Mon, 05 Apr 2021 08:53:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617637983; cv=none; d=google.com; s=arc-20160816; b=S/yB0rxOlIpKqpkoEAhBr2HYgrWk1qCPgPYLX3g4RlzfnzsVyriTaRfAS1y1nDDLYm vMi4iX3O1Ji6KcTtnFL9RIr3e3Ei9mTxYIx9vY4U+uVZTQQDtTwp0ScJGRQ81X9wQCV3 p0EKhNv4bAE/cQUtWXvYtCowPsC2/+0RmJ/XS4k8udy23v5LGMs1U5+yGY6Q6UsVkeS+ hPyAraGLNOyH4bg7wkaJE7l9ku8t7kG99eshqfcS5BnAxDMPdj9QT5kt6DXwbyMNAiFe s1yyilFOEKcMboTiRaQE+JAtFnh7CbdGVOLv1lKeb88Mw3P7hGvJtxbTbB0QmdQ2ftTQ ziiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EFk1G20DrReG90khQIbYik1uhlDhpt3a5NzrLt43wWw=; b=LpvZkn4xzxqxTlR98y0t7Y1bFs2lhBN/3bnbUeCfWD4q3QA8gu9efr74JoHhBh0NNz oYyTmZFao+oOvVCLeIkOpwc8B78r9lqbUjWVzMwBRCVei2r5QadhYLPL/i1T4MAa9Zok +XUqfjRVO6o9xBU3pEJv4hm7/3c8OTf1fsq9f2dIxemt9292iIysv8akhd2/Gwmm3mxv iHknCfZwCjkuA+I6B0am1XUe5i+1SGKMIDM7nP2oynt4qt1hIC8dMGtcOlMPyIk9nDIX BhuomQXBCsO+VFK5qtcxXLo+hO+86WPwb04anyCKT4luwSb8O+hG4m9PGtp7VYfI9ybC MrCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Z20R3dAw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b9si5368461ilo.116.2021.04.05.08.52.51; Mon, 05 Apr 2021 08:53:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Z20R3dAw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238396AbhDEJHb (ORCPT + 99 others); Mon, 5 Apr 2021 05:07:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:49676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237878AbhDEJFg (ORCPT ); Mon, 5 Apr 2021 05:05:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EDF44613A7; Mon, 5 Apr 2021 09:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613529; bh=PrvXvLexksylJ5hd1iSur2YhtvHzTqsiS9WEgISJ7Qc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z20R3dAwdigg/D2wSbxjHqIzKkVcJxdrH3HNi/HvNh4BzQtigX12rQZP2uAY8PFMZ n8paFEjhQ6M1+PiIQxg5zEvxZhlf1wz0GhM30unv7FHSyOnIAuNFQkmVd4RjzfVH+N 7S64T3cEHM9xEGbBk9sqGyLtfkVe2CSB4351D96o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Artur Petrosyan Subject: [PATCH 5.4 71/74] usb: dwc2: Prevent core suspend when port connection flag is 0 Date: Mon, 5 Apr 2021 10:54:35 +0200 Message-Id: <20210405085027.047740968@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085024.703004126@linuxfoundation.org> References: <20210405085024.703004126@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Artur Petrosyan commit 93f672804bf2d7a49ef3fd96827ea6290ca1841e upstream. In host mode port connection status flag is "0" when loading the driver. After loading the driver system asserts suspend which is handled by "_dwc2_hcd_suspend()" function. Before the system suspend the port connection status is "0". As result need to check the "port_connect_status" if it is "0", then skipping entering to suspend. Cc: # 5.2 Fixes: 6f6d70597c15 ("usb: dwc2: bus suspend/resume for hosts with DWC2_POWER_DOWN_PARAM_NONE") Signed-off-by: Artur Petrosyan Link: https://lore.kernel.org/r/20210326102510.BDEDEA005D@mailhost.synopsys.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc2/hcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/dwc2/hcd.c @@ -4322,7 +4322,8 @@ static int _dwc2_hcd_suspend(struct usb_ if (hsotg->op_state == OTG_STATE_B_PERIPHERAL) goto unlock; - if (hsotg->params.power_down > DWC2_POWER_DOWN_PARAM_PARTIAL) + if (hsotg->params.power_down != DWC2_POWER_DOWN_PARAM_PARTIAL || + hsotg->flags.b.port_connect_status == 0) goto skip_power_saving; /*