Subject: Re: most users of msleep_interruptible are broken
From: Arjan van de Ven <arjan@infradead.org>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: Matthew Wilcox <matthew@wil.cx>, Amol Lad <amol@verismonetworks.com>,
       kernel Janitors <kernel-janitors@lists.osdl.org>,
       linux kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <452CFD98.6010808@drzeus.cx>
References: <1160570743.19143.307.camel@amol.verismonetworks.com>
	 <1160571491.3000.372.camel@laptopd505.fenrus.org>
	 <20061011141651.GD27388@parisc-linux.org>  <452CFD98.6010808@drzeus.cx>
Content-Type: text/plain
Organization: Intel International BV
Date: Wed, 11 Oct 2006 16:53:35 +0200
Message-Id: <1160578415.3000.381.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 673
Lines: 20

On Wed, 2006-10-11 at 16:20 +0200, Pierre Ossman wrote:
> Matthew Wilcox wrote:
> > 
> > They clearly don't care about exactness; they msleep_interruptible and
> > throw away the return value, so they don't know how long they slept
> > before they got a signal.
> > 
> 
> It's broken then. That delay function should delay at least the amount
> given.


if you want that don't use the _interruptible variant. It's that simple.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/