Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3327101pxf; Mon, 5 Apr 2021 09:07:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpcIoqyRw9TIPTBOCYKiql75e2MBIWX5fJ38vE5yJhuVnfwpLrJisE6zHxqpWTate7Kjkz X-Received: by 2002:a92:cd4a:: with SMTP id v10mr20346894ilq.273.1617638833009; Mon, 05 Apr 2021 09:07:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617638833; cv=none; d=google.com; s=arc-20160816; b=WGcXQNAqiwXmHdja96nZiYBvtdWVWHqiL64+M+LTYbys+GqKZj2YJITP8BD9cqPNbd nmYZo4uzKRD2jR/K+GSZ0bU58WFI8Pv1mtWI2DroSSDqdLsJZVHvSKzRVopUZL/1l2Ha DXNbPP8XyjH0JEmYC/JfPwzOVzHmzJP/Lyo7s7zAf/zXkmuP4aJO0aqWQvby0kt+zcro RE74OoKExUUVURw2MCVRvnSWELIu0hjuAz+niT6XHAIEwod92hOz1rObGyy/B6BG4mpl D/tSTmP8XsXTGUZYu3cmSSuW7/bUyVC0LUSfVn7VTO4maoWKV7CDcpHHMfho5Fkml2qe SGag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dgDyPfFpLJ2BJJSnw7fnUVPEcuPUVLTO/5D0nbsce5Y=; b=Op2st+p6+ZEdUqg5qOElehPqPmz0Lse3Diw5QFE3ldVcjjwSOG+0KcRMr0JFBo/MrD adm62n5aJBN3ew8XAJb0/0uZ9CPfUzGBGtgpp46NJfSjqmwZXMwrndQDvbUpkbBPfUvj hofU3urkAv826QzlK83FDN1F8LN7iPNNdz+8qYre18YbcfwJqEAWT0TnmsVpeobQ/ZmB pQYqFl6mMjZ7w0Y7yHSQwVcsNu41qbUCnRwXE5tv2VQLztADjrwkVF7mLjEO/Mbq0Pke BfgJIzWBEJeo6vRjv/Ee91DSmZ/OlCHD1qmsTVl/v8qbmGcu5CVj+8BFoWBIKQcTLqcA 9AKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tb+4NJzL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r74si15099875ior.80.2021.04.05.09.07.00; Mon, 05 Apr 2021 09:07:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tb+4NJzL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240316AbhDEJO7 (ORCPT + 99 others); Mon, 5 Apr 2021 05:14:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:58372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238908AbhDEJLa (ORCPT ); Mon, 5 Apr 2021 05:11:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5484B613A1; Mon, 5 Apr 2021 09:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613869; bh=/zH+4GMJ1P9Oawjwxt+mIGiYAPTXdZT4rdssvtX63WE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tb+4NJzLKANt/HuaiQQPml2/PgPZfI8R+N+diKNavP8/ydDdcTh/5pO64z85ObMET LieVskUlmLKs0W7rzFZJtRSLbiuvLyQGuCMEivAphW43rqiiiEvS/CKaX4g+6yAtYX Z2ZD7EbGWHCyNCJa7e/I2M+3Z+//i+uE7tlUKQ9A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+b67aaae8d3a927f68d20@syzkaller.appspotmail.com, Du Cheng Subject: [PATCH 5.10 123/126] drivers: video: fbcon: fix NULL dereference in fbcon_cursor() Date: Mon, 5 Apr 2021 10:54:45 +0200 Message-Id: <20210405085035.100613544@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085031.040238881@linuxfoundation.org> References: <20210405085031.040238881@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Du Cheng commit 01faae5193d6190b7b3aa93dae43f514e866d652 upstream. add null-check on function pointer before dereference on ops->cursor Reported-by: syzbot+b67aaae8d3a927f68d20@syzkaller.appspotmail.com Cc: stable Signed-off-by: Du Cheng Link: https://lore.kernel.org/r/20210312081421.452405-1-ducheng2@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/core/fbcon.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -1344,6 +1344,9 @@ static void fbcon_cursor(struct vc_data ops->cursor_flash = (mode == CM_ERASE) ? 0 : 1; + if (!ops->cursor) + return; + ops->cursor(vc, info, mode, get_color(vc, info, c, 1), get_color(vc, info, c, 0)); }