Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3348540pxf; Mon, 5 Apr 2021 09:40:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrj6SxRwtyZatYIazTYOxonx08QYk5uz89fHmu6/jn1hsMxO5KJGeRd2eWkMHkSxbwwrm6 X-Received: by 2002:a92:2e13:: with SMTP id v19mr20098517ile.198.1617640848630; Mon, 05 Apr 2021 09:40:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617640848; cv=none; d=google.com; s=arc-20160816; b=QKlxEkCYhE53YFEwwZnG3LtqEJ3Dtxfw9asm/7JMTiICM7FLHXQxdv9TqC6KbYkvGI c8c9KeoT9n9Fcn7OeShslcx+l3d3wV2m8xqM1yi1BuUoM4blwRKkl6Hp29qd6D2j/X7M Nm56noUMF6MdKgU85IvnoaCSdlqurZvmuFeG8BF3vNQTbLekcIMdnTzZbwRxh+gAP10E qPHtzsfZLojO+MR27pMWKB6vEOBS+pCUf3AS9t5toRJbTdobpLMxkDT6W/m2L6uA4dEb fYcG1edMfIUrbu97SRn/Z3qdqf0HoGZluYAEo5CjCMUzRKljKyZX5xZYz+V35muyWaBD xVRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gd4ogePO6zNP2hgGQyO2Vz4VBpnhwIZTA5lbmTfstWA=; b=tEaY9+3P+hbgubFSZVFtQMFvVb96yc97LN1nhbHJN8KN742gvc+YPbKMKtBVSEUVMv sOhuq9DhatcLgAJ+t+s7g+9OcSq3vptcuuUNo6zorcfB1Ax/7fyNph/OEHvhH5R1WVO9 l95+UgfobONrox5q9zBOwa5fIDvK80d3+zED8hbmZoaCnU9sO3+PZPPZf7f/l1em3ebx 0KuE0rzSTRTbml0PgR3ht1jnVhetT4qR/PjtuNNaDu2GUmA5h5YRtD6JxYLa8Q0N2mb5 CqSiaCf7u4UYeBUeMOlYiKp4ZJwGXCLabPwRF7uLOZGqfmvEz9PZKchc4zj+SjBhdBn8 Ud1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WXzKNeXw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i22si15979298jaj.113.2021.04.05.09.40.36; Mon, 05 Apr 2021 09:40:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WXzKNeXw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239919AbhDEJO2 (ORCPT + 99 others); Mon, 5 Apr 2021 05:14:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:57516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239454AbhDEJKw (ORCPT ); Mon, 5 Apr 2021 05:10:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 195A061399; Mon, 5 Apr 2021 09:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617613846; bh=8tOAUDm/Lf22WRBS8h+MiR8qbiTrV9llhrSBXL/QJTY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WXzKNeXwrcb8GRZzccSoZAfHeX5wTAbroDsOersT7DC/mgUXql7uUOcaFl/KBoKPF b6w8ovHuP+TzgPsoxEZltWPHuZxK3K7E2jNiw0QoEIP4V4B6t7TxAIRdbnCYvdn6wP OgVD6ArWu5YqmV3OURf/Z/B2nHY7WpDTmrjFi6i0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Philipp Zabel Subject: [PATCH 5.10 077/126] drm/imx: fix memory leak when fails to init Date: Mon, 5 Apr 2021 10:53:59 +0200 Message-Id: <20210405085033.620798351@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085031.040238881@linuxfoundation.org> References: <20210405085031.040238881@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian commit 69c3ed7282a143439bbc2d03dc00d49c68fcb629 upstream. Put DRM device on initialization failure path rather than directly return error code. Fixes: a67d5088ceb8 ("drm/imx: drop explicit drm_mode_config_cleanup") Signed-off-by: Pan Bian Signed-off-by: Philipp Zabel Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index d1a9841adeed..e6a88c8cbd69 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -215,7 +215,7 @@ static int imx_drm_bind(struct device *dev) ret = drmm_mode_config_init(drm); if (ret) - return ret; + goto err_kms; ret = drm_vblank_init(drm, MAX_CRTC); if (ret) -- 2.31.1