Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3351371pxf; Mon, 5 Apr 2021 09:45:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9B4Ynrvl9UNCbgFnWUXKkay+dCtAQP1RjNNNioWnddA1bLQ+/Pn/R+DSmOm0ZVDMydQcg X-Received: by 2002:a05:6402:214:: with SMTP id t20mr13688492edv.229.1617641103577; Mon, 05 Apr 2021 09:45:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617641103; cv=none; d=google.com; s=arc-20160816; b=mtaTPsrr5QmTflBYojNZKyxf7+21PKltcpR6hhBde7+Qnh9LUUXSO92+gixb+9+uh7 QKORm6/Ie2u9n7cieTTN1NshbSEcefIBr+kfylOilJ+VAlHhIQlSXNg351CO7P5sbwav 0fypAawe1t+alV7v8xfH4Y1TA3eT9t23fMR+ICoblUscKQMN7amCwxNTcvzZJi+dBnaQ GTPfUXiJwlVc6WDndJMJzKk9EPKibsG2Pqxsm0JY6rIQBhTzS9d06Gb5t3nfFYp6bWWP MowNA7eUiclZG/zLTvflZMgyw9/iE1MCC/OHHbQR0YwM39l62gxuYSxKOIz+dE2wz4e4 8DoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WCcLO0nONy23Q5AiZI8bLKGaLQ/9QLTSGgSM+C4Y2c4=; b=yvfG+Y7WqEokq+Si7vzp9kjxcxPL9iy312dbzLbWK1vr4mx4IN+aeUEBKxKEWZzAqQ pRgOUxB9Zxlp6OV0FiqnDPufSBwt5df83MbusjznoddmwBs9RcG2LoGw6rL22NOy6eFu rjFtBuZ/BTcqHYMsmcAIZjDIHpzwdzaqeFKJdBHO/8N3ZZ8znKXdDu57UKBr52YCdsFf 1e35vFnmdXY0RDGy1EKQc4jP4A8qvHAc8SceHaTO7WiZsr0Y3K618BXmN/opop6V24j5 DJK37+1NA1XoiTOFTX3BRetqPpU2MtPPYaHX0hfCD1cTYUkJCvv1Zpkw4xY9w6hniXyx wRCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PUoJHrhy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id go18si14477710ejc.187.2021.04.05.09.44.40; Mon, 05 Apr 2021 09:45:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PUoJHrhy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239710AbhDEJQx (ORCPT + 99 others); Mon, 5 Apr 2021 05:16:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:60990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239482AbhDEJNZ (ORCPT ); Mon, 5 Apr 2021 05:13:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7949361002; Mon, 5 Apr 2021 09:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617614000; bh=ih4y904yWzaAhA7DVefag97qpt+xUl+gClXPC0J6d0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PUoJHrhyC+0pT4ujmPtcOEuGuFC2xaCemYmyU/WhC+4sO3/jN5L79YihJLLp60PZ5 kJyegMC++Wpryia/6tCAEu9vmw90WpXtnZd8O+SBe2sKr6Rb19iRk9nknzEsDbpKkd MnfqgDh8pD+QCkTrXqUnnWeQSZHr/C9oF9EJ6C2w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bard Liao , Kai Vehmanen , Rander Wang , Mark Brown , Sasha Levin Subject: [PATCH 5.11 029/152] ASoC: rt711: add snd_soc_component remove callback Date: Mon, 5 Apr 2021 10:52:58 +0200 Message-Id: <20210405085035.200100334@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085034.233917714@linuxfoundation.org> References: <20210405085034.233917714@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bard Liao [ Upstream commit 899b12542b0897f92de9ba30944937c39ebb246d ] We do some IO operations in the snd_soc_component_set_jack callback function and snd_soc_component_set_jack() will be called when soc component is removed. However, we should not access SoundWire registers when the bus is suspended. So set regcache_cache_only(regmap, true) to avoid accessing in the soc component removal process. Signed-off-by: Bard Liao Reviewed-by: Kai Vehmanen Reviewed-by: Rander Wang Link: https://lore.kernel.org/r/20210316005254.29699-1-yung-chuan.liao@linux.intel.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/rt711.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/soc/codecs/rt711.c b/sound/soc/codecs/rt711.c index 85f744184a60..047f4e677d78 100644 --- a/sound/soc/codecs/rt711.c +++ b/sound/soc/codecs/rt711.c @@ -895,6 +895,13 @@ static int rt711_probe(struct snd_soc_component *component) return 0; } +static void rt711_remove(struct snd_soc_component *component) +{ + struct rt711_priv *rt711 = snd_soc_component_get_drvdata(component); + + regcache_cache_only(rt711->regmap, true); +} + static const struct snd_soc_component_driver soc_codec_dev_rt711 = { .probe = rt711_probe, .set_bias_level = rt711_set_bias_level, @@ -905,6 +912,7 @@ static const struct snd_soc_component_driver soc_codec_dev_rt711 = { .dapm_routes = rt711_audio_map, .num_dapm_routes = ARRAY_SIZE(rt711_audio_map), .set_jack = rt711_set_jack_detect, + .remove = rt711_remove, }; static int rt711_set_sdw_stream(struct snd_soc_dai *dai, void *sdw_stream, -- 2.30.1