Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3367034pxf; Mon, 5 Apr 2021 10:08:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPowPnDqXZ5yh5SS9Gam/HvEdfgP+jeaYHwKMBSURXgx30MPlc8bJheUC2e1POqXg1y3v2 X-Received: by 2002:a05:6602:330d:: with SMTP id b13mr4626814ioz.46.1617642529846; Mon, 05 Apr 2021 10:08:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617642529; cv=none; d=google.com; s=arc-20160816; b=Xw8xZa1GMR0Amt7wi/9U1CLv4K32NRHreorgBfRSrq/7ISTcb3aMzaNDzo+zjBCV8+ Wu/ET0oye01FAMLF1tfAg6sjKOC5lJFAe5v4SsAArbgr7j1o750bd6BZ3KOg5onVnvAh eP84pf9aMOLrNUQ7axEQiblU7I/mFuRw9X/0KlHyLRZZm6SkFAUc6+zKn1EwHUIOjSy/ kn8NQkp59l3HNp4uLj3ob1KkFPyhSlF/d2yni619vYK7Hf3hoo5r50zbPSK1r95G1haa GcdpDeJB0ndOQWLfV73B/H3uFm6gv51A11Nsh+F/DdTXuvJCXWur+wrwpyqCwciXK9JD QIqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xonZKZIhpShCBN236uqEfGwcYD9SHQEG/RP+f/gzQqM=; b=BnJDYbTlB0oBrVNgZVeuln4U61is/Z3kXGdyYtYLjRYeNvn8hzGEhqjUg/Ncw7mGma 9U/18wsRVCPnx/fCkqiOoUUoVjbOCyRD7AUpjlrZ2U5qVhLxXjQR2M5SNI24/7Yf3vG7 2KrbR9yI//+JzrYSnydbFSk+6R5XV6LS35+r3UDNK9qfMVhKE7r8xZJvmqFt7zQlNbjt 4kOu3V2w65JgVS+d6TH9HS+2gPSMKrU6n95dEpkN7YhSLClBv+zNLrauqbxIcge/UIkZ l/o9NproVCnyZzFMpNewJ9HmQWorPAcQs4jNja3+8IMklD3t/LTO0/FYlFdJCwfMBSGb hvMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jSo4NAVJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a11si15778652jaq.60.2021.04.05.10.08.36; Mon, 05 Apr 2021 10:08:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jSo4NAVJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241034AbhDEJTi (ORCPT + 99 others); Mon, 5 Apr 2021 05:19:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:35680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240314AbhDEJPl (ORCPT ); Mon, 5 Apr 2021 05:15:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D2F0061393; Mon, 5 Apr 2021 09:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617614135; bh=mAe0AMo/Vz3uUUPI3lRQeA7kElFgeIoVf38DfeJpueQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jSo4NAVJMaXLgOuBI4CfX6++yb0xnre6O6Ny9BEDDQhTXdUqfFRo5w9KGQOQqTibE itbykmZ1841X/VS49L8hTUvmzztdkooIeciIMGs/YSUpXOn/Zt6xVtwL5sAQeEsdj0 zADR3W+lrs7ULzADrmQO5rF19yyTKF7mhMGKwAhM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Philipp Zabel Subject: [PATCH 5.11 095/152] drm/imx: fix memory leak when fails to init Date: Mon, 5 Apr 2021 10:54:04 +0200 Message-Id: <20210405085037.335242081@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085034.233917714@linuxfoundation.org> References: <20210405085034.233917714@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian commit 69c3ed7282a143439bbc2d03dc00d49c68fcb629 upstream. Put DRM device on initialization failure path rather than directly return error code. Fixes: a67d5088ceb8 ("drm/imx: drop explicit drm_mode_config_cleanup") Signed-off-by: Pan Bian Signed-off-by: Philipp Zabel Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -215,7 +215,7 @@ static int imx_drm_bind(struct device *d ret = drmm_mode_config_init(drm); if (ret) - return ret; + goto err_kms; ret = drm_vblank_init(drm, MAX_CRTC); if (ret)