Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3373152pxf; Mon, 5 Apr 2021 10:17:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVc9KMrM2qdS3bgeWuV5090liUcwCjtfgLwZt++8YbllNjgq97aOlsiaA622XnkivDYO4W X-Received: by 2002:aa7:d484:: with SMTP id b4mr32692967edr.63.1617643056075; Mon, 05 Apr 2021 10:17:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617643056; cv=none; d=google.com; s=arc-20160816; b=VzlRawQGaiazE8pYWlfVAFFnMq+fg+PH7u2LtNyJLiYwZdFYbC8YSmOEtD8lKhmhbe /COM2yRm+JslJL1vlMBaM2cjnJXDL1tOyFOIxVFOFpOd7CDwCdc6HbRdxpQVYoFTgJ2a OkV7la2/aKnWWWeilapxxLMttmzRRwe25EzZ6/OU3UQGfkvfwxo7rieIfO9qbbtTmmno RJYG2TV8v8uARYwwz1htrjwUx4PoxwyTTHbCXJnuBtvAUmmUHz4cJo25Jrzy8cksJEaM DNtk2SIn9OADw7E4x6TlGcoxMh5RPLFLa2q+VdDwZwzQYf9ggDKGfZOwWhiiOgh7DORP zf/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Wddt5ajYYqMtm/JDf76k0dAfVuuh4sVhR6VNM/DLbNo=; b=pnHAZ4F7dCLWxC80TiunTTSIyLCMSHAjv+JjHdNZHX5nxLTKhdRNFUfTNxEBOxALy4 /CeFptbpXu95Rt+tmF5O7WfuLcidor5S9xFi6UvQZkBGT8EYFaR9G/Fudgy6055QrZLa RyO3aERDX71GjZ86CX4c90j4UQNbTiYJkENJkww6zdL+DSIXgmAJUuyhQgJNAwkWMiS1 1o3m3rF+6+hJS29AOy7INN5VNZe2lWzdW9amT+U9mbV/WlbklALMfHdrYnq0Qon4DZ0i vtsT1RhgrfipqwjIY8pyO7pdwJ5TPjW4tq88bE/LFECDoVlin+WiXNJTSggZ550T7w4t zhxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W+jmMikc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c21si14435992edt.47.2021.04.05.10.17.09; Mon, 05 Apr 2021 10:17:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W+jmMikc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232663AbhDEJU6 (ORCPT + 99 others); Mon, 5 Apr 2021 05:20:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:37394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240673AbhDEJQN (ORCPT ); Mon, 5 Apr 2021 05:16:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1E6A7613C1; Mon, 5 Apr 2021 09:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617614167; bh=5wzuOc2+vaYdYoEDiAHvdDZik+tc70rjc23ZwEXT4yk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W+jmMikc/aUaEUkHgB4z3LB24WWn1P9cLwsLs64/pMlweWyesf7O9s/sasooNoOHr 6W1+e+jKINoD5ByZaPGWRk3QkmebNYPAxN11QQWzvulVgshXkgHeT75riEdVXdGF3F tFNn0mlcM6IzgBzAc+kfkJax35hKbboDITmkP5Y0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai Subject: [PATCH 5.11 072/152] ALSA: hda: Re-add dropped snd_poewr_change_state() calls Date: Mon, 5 Apr 2021 10:53:41 +0200 Message-Id: <20210405085036.613190905@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085034.233917714@linuxfoundation.org> References: <20210405085034.233917714@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai commit c8f79808cd8eb5bc8d14de129bd6d586d3fce0aa upstream. The card power state change via snd_power_change_state() at the system suspend/resume seems dropped mistakenly during the PM code rewrite. The card power state doesn't play much role nowadays but it's still referred in a few places such as the HDMI codec driver. This patch restores them, but in a more appropriate place now in the prepare and complete callbacks. Fixes: f5dac54d9d93 ("ALSA: hda: Separate runtime and system suspend") Cc: Link: https://lore.kernel.org/r/20210329113059.25035-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1025,6 +1025,7 @@ static int azx_prepare(struct device *de chip = card->private_data; chip->pm_prepared = 1; + snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); flush_work(&azx_bus(chip)->unsol_work); @@ -1040,6 +1041,7 @@ static void azx_complete(struct device * struct azx *chip; chip = card->private_data; + snd_power_change_state(card, SNDRV_CTL_POWER_D0); chip->pm_prepared = 0; }