Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3388950pxf; Mon, 5 Apr 2021 10:42:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxghKHvlp4IMMSHBM/IAZK5X3VaXfwARx8Mngzhfe137JyM3Rt91Mb6vCQIEwfAQoWEUhZe X-Received: by 2002:a02:a889:: with SMTP id l9mr24844969jam.1.1617644555149; Mon, 05 Apr 2021 10:42:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617644555; cv=none; d=google.com; s=arc-20160816; b=hLii1cvZY3C/c4mD2sVL8BzUW3+akgZt9uuKvZFqK//lUbuzlIzfE5/btTVvUAFcqY ziKW85O4i+/8tHYNiHGI10MyqWsFMe3q3m7nasPhG07ARKSI3UWayuiPEcYjoxKXHnnw B5rVtM6OBniyRuaq4GNz/YmRCtmqRM6QN4OUfm1xeyD5iWKW3+zxlpZLI0parONSQZ+w LPFxVIOFXt5xAzfCcGUgPfQTnlUnCWOlCm8lkWPLQnwIEmXqJWulIzPCTO4KTAFqKRxV NT6ftQbKs5YXC/sJa1zNDHdqfatgUYVanHDciQkCQ8nARjxMvgx7s4pfE2VcFiKsttQR nsXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EFk1G20DrReG90khQIbYik1uhlDhpt3a5NzrLt43wWw=; b=RqLKdCmS+J9VmOW3+ozjRSy0F489K/H1y5sInwm59yXb3skRbKfMeYagANHjo3pFpX qNelOnc3dv6W6m++tKDTrdbrCVOUHESboZ4eCTbij0x9DmCh6AHsMVr+LI4HmByFTvHe xz+jWjqPJLOzlBmwuZ+Sid/FkZyc2tUu8QfEMm6CQJGQc7XPebQZcDb0wVeTNZxoSGie Y5HMltQdkgwZ0pAmi1rZI634avpjarx3r0SB2P5UBDXojo+wntu+KTZtgOJ7YtVq56DW GgjMD8PsuiQ7VugFoYoARAgWRGN1aosoN38FaoJjfGJKtVfSxzooT3wsfCMCRf+vqdKz SoVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tOKuXg1L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v13si10232707ilu.127.2021.04.05.10.42.18; Mon, 05 Apr 2021 10:42:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tOKuXg1L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240659AbhDEJXC (ORCPT + 99 others); Mon, 5 Apr 2021 05:23:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:39784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240084AbhDEJRo (ORCPT ); Mon, 5 Apr 2021 05:17:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9E3B1613A6; Mon, 5 Apr 2021 09:17:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617614258; bh=PrvXvLexksylJ5hd1iSur2YhtvHzTqsiS9WEgISJ7Qc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tOKuXg1LWZOsI6pBWiThBoHrWUFfM1nPv86MqttNqBy5QiuDH2OirY56iN0sKFYn2 EXWYCBKsQF93WQrUpPChlg+VGpml8JL7fabebTUYIHBEJJ25YkduF4nKd/3Ci1lNCC K6Ia7JmaniMXkk9N1YaapX5wADgXzVfb3vMM3o4Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Artur Petrosyan Subject: [PATCH 5.11 141/152] usb: dwc2: Prevent core suspend when port connection flag is 0 Date: Mon, 5 Apr 2021 10:54:50 +0200 Message-Id: <20210405085038.803864285@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085034.233917714@linuxfoundation.org> References: <20210405085034.233917714@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Artur Petrosyan commit 93f672804bf2d7a49ef3fd96827ea6290ca1841e upstream. In host mode port connection status flag is "0" when loading the driver. After loading the driver system asserts suspend which is handled by "_dwc2_hcd_suspend()" function. Before the system suspend the port connection status is "0". As result need to check the "port_connect_status" if it is "0", then skipping entering to suspend. Cc: # 5.2 Fixes: 6f6d70597c15 ("usb: dwc2: bus suspend/resume for hosts with DWC2_POWER_DOWN_PARAM_NONE") Signed-off-by: Artur Petrosyan Link: https://lore.kernel.org/r/20210326102510.BDEDEA005D@mailhost.synopsys.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc2/hcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/dwc2/hcd.c @@ -4322,7 +4322,8 @@ static int _dwc2_hcd_suspend(struct usb_ if (hsotg->op_state == OTG_STATE_B_PERIPHERAL) goto unlock; - if (hsotg->params.power_down > DWC2_POWER_DOWN_PARAM_PARTIAL) + if (hsotg->params.power_down != DWC2_POWER_DOWN_PARAM_PARTIAL || + hsotg->flags.b.port_connect_status == 0) goto skip_power_saving; /*