Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3389266pxf; Mon, 5 Apr 2021 10:43:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOn9vnUeB2OlM+n/5m42L/nsKttjUSc8drkUtuxq3yTnYX9ipSce8xyBDk94IMZcG1hy5B X-Received: by 2002:a02:cc1a:: with SMTP id n26mr25029922jap.21.1617644588990; Mon, 05 Apr 2021 10:43:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617644588; cv=none; d=google.com; s=arc-20160816; b=raY8BUWFH+wghpz8xz3FV7rlVH/wIDawxuWMW6XgygRCPtPWSt6DVh/orVjfjoJkAO no5FeuAatP5Fi2InronnZBQk256NYrpr+y1mMK2I05VJ5vgaffRxHyq49jlrGYfcbWkf G7ZXp4dHsLbuz3aWONWZpr1aD4GNFyxJjBmKdu5rGE5WRw5My0uJkcwHETtysDzTQA93 JaHvgMwfd2ORSMXoHdH7aj2HZCGJhU1Xo0vFKnaERXptG39miGW//Hjq436OxoRTuwdB DMp7VoMnGSx03BIBkIwMH0g3HE2DDlGHj2si0HeX8keZCz0CLOyGM9u0uMw+bOoWGu/X fJgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Thxoaiep67ZWl/5l2Ko5V7DZ/90OEFb0BIpwY7jpXIY=; b=RWQ0Xf2F3hr+LxFmbk5150EmRBH6qxx4UNdJIoU4sH5hMDci3M7NpGUe/i3YQYrpvR x+ul/ntAdnKKWmT8LMolFF6ULAj/tgWjJtAmrjkxiiBnAEUWr36Y4+4QRKlPyGT9m982 w94Nktg/+oujXptW7mSku5EBR9Zo1fGd/4nikVCMTsyfYwl57TppElY3EAnGX2/90SOF gnaznD54M0qlt58b9v6GuPIlXahUX4+TdhjwvE1lfOeyyQIJjmf4yfvyuZFZJ/C9/soW 2UWdWHLtyOkXN2o7CHGKTe+XcpdR7fZdS38GP5SThC7VTS8x0vktT9tKrMnWp9KSSJzm LkCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=erI6o98w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f14si14899177ilu.78.2021.04.05.10.42.57; Mon, 05 Apr 2021 10:43:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=erI6o98w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232387AbhDEJYC (ORCPT + 99 others); Mon, 5 Apr 2021 05:24:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:40772 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239963AbhDEJST (ORCPT ); Mon, 5 Apr 2021 05:18:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2D7F660FE4; Mon, 5 Apr 2021 09:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617614293; bh=s3DzKyLrNRce3GMjrPJ3Z9Tn1J3unfFRWWsqvHZd7wY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=erI6o98wKXqfBmMzOcvh1cL0rSd35yiNFfjTb6nS3c1T0mmR+BX4+Nd7KC21ConR5 EGmED8vtZUECzafD1cO2HTRze00RCWMe/toLOPdDvF1x1Afjy3PuEFkWeJoWf2Vb6C s6ETsKBwj1sRsUET5gXiSvFfYZuRBx7am5hsn7eY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+b67aaae8d3a927f68d20@syzkaller.appspotmail.com, Du Cheng Subject: [PATCH 5.11 148/152] drivers: video: fbcon: fix NULL dereference in fbcon_cursor() Date: Mon, 5 Apr 2021 10:54:57 +0200 Message-Id: <20210405085039.029929021@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405085034.233917714@linuxfoundation.org> References: <20210405085034.233917714@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Du Cheng commit 01faae5193d6190b7b3aa93dae43f514e866d652 upstream. add null-check on function pointer before dereference on ops->cursor Reported-by: syzbot+b67aaae8d3a927f68d20@syzkaller.appspotmail.com Cc: stable Signed-off-by: Du Cheng Link: https://lore.kernel.org/r/20210312081421.452405-1-ducheng2@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/core/fbcon.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -1341,6 +1341,9 @@ static void fbcon_cursor(struct vc_data ops->cursor_flash = (mode == CM_ERASE) ? 0 : 1; + if (!ops->cursor) + return; + ops->cursor(vc, info, mode, get_color(vc, info, c, 1), get_color(vc, info, c, 0)); }