Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3400171pxf; Mon, 5 Apr 2021 11:02:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxN3V/whPNv5QXT8EopSssLRB/PC8RuF8huMUZ4LXlns0l91F2P9QG0ax+anz7cvJuto/3g X-Received: by 2002:a05:6402:17d6:: with SMTP id s22mr32564052edy.232.1617645719757; Mon, 05 Apr 2021 11:01:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617645719; cv=none; d=google.com; s=arc-20160816; b=ilsfLecxYH6nnhLzbt48Ll4Q+FHrvbHVq1ew64Og4b+R3G64VdOSPjlNyVFObYB8W1 /qfI9OHH/xBuV+nfJFzAFlrVSLmR9+QyJgdEBtcwhq41avYMIFYINrH3DdPOLiRMEhRc PcJ3FLQKio+Bj01/tn+g/o9L8Spc/IkFrzTjrrrolwyT4/CCrgUh2r2ElWU8+hwzr0qw XUT26n6XuzkvVMuGVXtUbAtPONuLN/2nEamZpFa3a4bUnb3eTH/IZP0sZ5ibJxrk8WR0 lczP1t0f9i3YZPpxYBmEm8/33b7IwIein3SeYiOe6Wqng3XMNg0at4Dll3v7vrXvV6Gv FhEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=l0xFAPePFrO7zL/I6Nb7nN68Pbr8PRf+qIptSwFypec=; b=jx4fVkjPcRAUnp2cV1vbKCUkHTkmFarJGokS6LyMTMJRNkHvLwLhHjNcQkY0SkmxOY TCAb4QRAwc/keEGkpV8TngoE7zyYtcoQJGP/KaX1Y2xRNM/BtCBkB5A+6eHfo+Ssgs55 IhIVDCdSOIjCpwkv5obDI45n3BQRp8n1kdqTHAjjSQXKVhSon5qmERzr47yu5Vs2HAxY NN47QdVEaQd8WqJSVRXgiAwoYzr8GwAuRh0kM8Cw2bnJjGxAZLJHnH0UZRU+l2NEEIui lLzNk3o8WBbBK/XQzEWi1xaEmVKh4RLERZ1ULsBLpQAH1mqPVVsLlJuGUxrxI0ggZE1z 94cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KZbHIoPo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n9si7832632edc.437.2021.04.05.11.01.35; Mon, 05 Apr 2021 11:01:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KZbHIoPo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232032AbhDEKdI (ORCPT + 99 others); Mon, 5 Apr 2021 06:33:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:53586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbhDEKdI (ORCPT ); Mon, 5 Apr 2021 06:33:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A2F2561002; Mon, 5 Apr 2021 10:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617618781; bh=0wHqgcE2bXp1m+qUNuoVmhAvJ8AW/07Qzz4FNRVqzuo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KZbHIoPokEVhDtfXOmO2haLraKCJUwxpn1iQCDR8djRjmi0ndHm5PfLL1hvX7MQIY 3l7qbnlDMnThYVst36sFIeFtyus8rYiFONpKIU628JXeAfkuxSWs9mzt0XmQJfTEZG 1jbw6Pm5JP2vzNc6hqPY3YE+a24f1Y3mPjzcuRzQ= Date: Mon, 5 Apr 2021 12:32:58 +0200 From: Greg KH To: Luiz Sampaio Cc: zbr@ioremap.net, corbet@lwn.net, rikard.falkeborn@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/9] w1: ds2438: adding support for calibration of current measurements Message-ID: References: <20210403012446.381516-1-sampaio.ime@gmail.com> <20210403044547.390226-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210403044547.390226-1-sampaio.ime@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 03, 2021 at 01:45:47AM -0300, Luiz Sampaio wrote: > The following patches aim to make a user able to calibrate the current measurement of the DS2438. This chip uses a offset register in page1, which is added to the current register to give the user the current measurement. If this value is wrong, the user will get an offset current value, even if the current is zero, for instance. This patch gives support for reading the page1 registers (including the offset register) and for writing to the offset register. The DS2438 datasheet shows a calibration routine, and with this patch, the user can do this quickly by writing the correct value to the offset register. This patch was tested on real hardware using a power supply and an electronic load. > Please help to review this series of patches. > > Best regards! > Sampaio > --- > Changes in v3: > - I accidentally added a wrong line that would not compile. I'm sorry. Fixed it. > > Changes in v2: > - Using git send-email to send the patches > - Adding documentation as requested > - Separating the coding style changes in different patches as requested > > Luiz Sampaio (9): > w1: ds2438: fixed a coding style issue > w1: ds2438: fixed a coding style issue > w1: ds2438: fixed a coding style issue > w1: ds2438: fixed a coding style issue > w1: ds2438: fixed a coding style issue > w1: ds2438: fixed a coding style issue You can not have different patches that do different things, yet have identical subject lines. Please make them unique. thanks, greg k-h