Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Min Li <min.li.xe@renesas.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
        "dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH next 2/2] misc: Add Renesas Synchronization Management
 Unit (SMU) support
Thread-Topic: [PATCH next 2/2] misc: Add Renesas Synchronization Management
 Unit (SMU) support
Thread-Index: AQHXKNYoPNBeg4xORkG1GcxDTKZKeKqkI0+AgAEGM5CAAFEKgIAAeY4Q
Date:   Mon, 5 Apr 2021 13:53:10 +0000
Message-ID: <OSBPR01MB47735215095EF20C0B0AA793BA779@OSBPR01MB4773.jpnprd01.prod.outlook.com>
References: <1617487714-8312-1-git-send-email-min.li.xe@renesas.com>
 <1617487714-8312-2-git-send-email-min.li.xe@renesas.com>
 <YGmQKyweNi3lWoGM@kroah.com>
 <OSBPR01MB477323303D45865B0B2AD96CBA779@OSBPR01MB4773.jpnprd01.prod.outlook.com>
 <YGqwGeSCdJwH33od@kroah.com>
In-Reply-To: <YGqwGeSCdJwH33od@kroah.com>
Accept-Language: en-CA, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 21192dfb-4de7-4a41-8086-08d8f83a263a
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2021 13:53:10.3076
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TbWcRV4UBNMrU6G2GxPH6IeLz3rSzlgHjn3HVHzSINaR6VsIHMR375t7FWOlu5fcUQEK+eqjGUF74n7Tn4kJRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB4707
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > >
> > > Any specific reason you are not using the misc_device api?  That
> > > would clean up this driver a lot, there's no need to create a whole
> > > class just for a single driver.
> > >
> >
> > Hi Greg
> >
> > No specific reason. I just didn't know the existence of misc_register A=
PI.
>=20
> Your file is in drivers/misc/ :)
>=20
> > Do you recommend using this API to create the device?
>=20
> Yes.
>=20
> > If yes, can you tell me how to obtain a appropriate MINOR number from
> > miscdevice.h?
>=20
> No need to reserve one, we don't do that anymore, just ask for a dynamic
> value and the next availble one will be given to your driver automaticall=
y.
>=20
> thanks,
>=20
> greg k-h

Thanks, I will change to use misc_register and get back to you.

Thanks

Min