Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3588277pxf; Mon, 5 Apr 2021 16:42:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTHkr+PzGGYUwDpS/xBQBPq9X2XuNTfQq5oM3UbkHkfM9Gj9GrV/adcJw/6GyCo64PQZot X-Received: by 2002:a92:cda4:: with SMTP id g4mr22307008ild.208.1617666149623; Mon, 05 Apr 2021 16:42:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617666149; cv=none; d=google.com; s=arc-20160816; b=ofjTVLw1xtn1OA5SQI4Wf1M1Hj8bBlrqErWCH/p/uhqw9+a+mpLkER9EN99U/An5VR UTsnrVJgxUPkBwTHwsNYNxPGxm8VEZwpcPb8OIpECJemVHQOxyn1ItgU3IWXTIlq6rz6 6yYTBWYeSINnXO23j0eP8tj1U7+bkhM/XPwHer/mL0Ine+DoknvFBoYBNxsnO7c3iS+g NATkXS58O6Z0atU8f7S6JOrrFG4IL2NUp1h51Z2x5LiM0nEiYC80w4ROxulB9ivQMmwX Ha/APzdx0rHJqiqBxel0qxd3PPAiEz2mpb62j51VxDYsSsOJUbDRfz6Chvz9fAOnjiFh mNEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:ironport-hdrordr; bh=m8Dataga3xfuI+nHI29a5Fk6mB40BQFAAaQ6RzGJC0w=; b=olZEYnqWJKCUV4uvyy6qRBqRvXodx5rEGScvN6gfaQv1KV9DEf1Z0eSX6cf1uKtVmL OpBrkewxoLi7BKcX5FRy+J3LtC7hQ1921mjYmfYKtbtUcXJ8Z8eHbAQ6qXTstcryIu6o jB63B5e7LDO3V2+RlkrARZI6rX7Xt54STyzISmG4ZGr4A4HezVsLEV4rPiqd8MHUKuPA U4v/T9QnzClWFehvlWqZe3+1myq0jB3qAY9B54Kpe1aDnI0ftl9h8+8c9l4UfPOsJHc1 ws4oYJqg26NVy0HQFFSIbQb5M4N6Dgo36Xe7zw/4oVS25byaW+DmzHadWx1xNG4pkOHV IvRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si14687206ilh.26.2021.04.05.16.42.16; Mon, 05 Apr 2021 16:42:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230421AbhDEPKD (ORCPT + 99 others); Mon, 5 Apr 2021 11:10:03 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:48400 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230391AbhDEPKD (ORCPT ); Mon, 5 Apr 2021 11:10:03 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3AxNhREK6xgeoKKlONSAPXwCnXdLJzesId70hD?= =?us-ascii?q?6mlaTxtJfsuE0/2/hfhz726RtB89UGwt8OrqBICuWnXZnKQe3aAwOvOYUBDiqC?= =?us-ascii?q?+UKuhZjLfK5x3FN2nA+vVG1aFmGpIObeHYKVRhl8717E2ZPr8boOWvy6yjiefA?= =?us-ascii?q?w3oFd2gDV4ha4wh0EQqdGEFtLTM2ZqYRLoaW5cZMulObF0g/U8LTPBU4dtTYq8?= =?us-ascii?q?aOvJzrZgNuPW9E1CC+yQLt0rL8HhSCty1ybxpEy94ZnlT4rw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.81,306,1610406000"; d="scan'208";a="377777468" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2021 17:09:56 +0200 Date: Mon, 5 Apr 2021 17:09:55 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Beatriz Martins de Carvalho cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Ending line with argument In-Reply-To: <82580331-13dc-ed79-72e7-3984fd2f75f9@gmail.com> Message-ID: References: <20210401195457.24512-1-martinsdecarvalhobeatriz@gmail.com> <82580331-13dc-ed79-72e7-3984fd2f75f9@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Apr 2021, Beatriz Martins de Carvalho wrote: > > Em 01/04/21 22:16, Julia Lawall escreveu: > > > > On Thu, 1 Apr 2021, Beatriz Martins de Carvalho wrote: > > > > > Cleans up check of "Lines should not end with a '('" > > > with argument present in next line in file emxx_udc.c > > The coding style documentation encourages remaining within 80 characters. > > I'm not sure that the ( warning is worth increading the excess beyond 80 > > characters (or introducing it in the last case). > > > > julia > Thanks, prof Julia, how the checkpath now warning only if line length of 100 > characters, I used it for reference. I think it was changed so that people would leave as is code that was really more readable at 85 or 90 characters. But the documentation still encourages 80 characters. julia > > I will take the suggestions of checkpatch with more attention. > > Beatriz > > > > Signed-off-by: Beatriz Martins de Carvalho > > > > > > --- > > > drivers/staging/emxx_udc/emxx_udc.c | 11 ++++------- > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c > > > b/drivers/staging/emxx_udc/emxx_udc.c > > > index 741147a4f0fe..20f53cf6e20f 100644 > > > --- a/drivers/staging/emxx_udc/emxx_udc.c > > > +++ b/drivers/staging/emxx_udc/emxx_udc.c > > > @@ -1073,9 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc > > > *udc, struct nbu2ss_ep *ep, > > > i_word_length = length / sizeof(u32); > > > if (i_word_length > 0) { > > > for (i = 0; i < i_word_length; i++) { > > > - _nbu2ss_writel( > > > - &preg->EP_REGS[ep->epnum - > > > 1].EP_WRITE, > > > - p_buf_32->dw); > > > + _nbu2ss_writel(&preg->EP_REGS[ep->epnum - > > > 1].EP_WRITE, > > > + p_buf_32->dw); > > > > > > p_buf_32++; > > > } > > > @@ -1225,8 +1224,7 @@ static void _nbu2ss_restert_transfer(struct > > > nbu2ss_ep *ep) > > > return; > > > > > > if (ep->epnum > 0) { > > > - length = _nbu2ss_readl( > > > - &ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT); > > > + length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum - > > > 1].EP_LEN_DCNT); > > > > > > length &= EPN_LDATA; > > > if (length < ep->ep.maxpacket) > > > @@ -1462,8 +1460,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc > > > *udc, > > > for (limit_cnt = 0 > > > ; limit_cnt < IN_DATA_EMPTY_COUNT > > > ; limit_cnt++) { > > > - regdata = _nbu2ss_readl( > > > - &preg->EP_REGS[ep->epnum - 1].EP_STATUS); > > > + regdata = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - > > > 1].EP_STATUS); > > > > > > if ((regdata & EPN_IN_DATA) == 0) > > > break; > > > -- > > > 2.25.1 > > > > > > -- > > > You received this message because you are subscribed to the Google Groups > > > "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, send an > > > email to outreachy-kernel+unsubscribe@googlegroups.com. > > > To view this discussion on the web visit > > > https://groups.google.com/d/msgid/outreachy-kernel/20210401195457.24512-1-martinsdecarvalhobeatriz%40gmail.com. > > > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/82580331-13dc-ed79-72e7-3984fd2f75f9%40gmail.com. >