Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3740488pxf; Mon, 5 Apr 2021 22:01:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTHY6B+6RIC+WxZf042/iLQHJfSXc3BdKcjj6VKK3MbHbaAzUmBY7b3js1uh0b3+f3h25H X-Received: by 2002:a17:906:dfcc:: with SMTP id jt12mr32307359ejc.31.1617685283325; Mon, 05 Apr 2021 22:01:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617685283; cv=none; d=google.com; s=arc-20160816; b=OdDCr4/fLrgSxvNrxlg9Ejp38+kEJc26cYrThH4byucb7n2xIW0+qldpMGTrKaEEnR ekqA5Pf0IwUUf5U+s9ENrZLqXcHC4IjwXF79W1h0wjaEZXXZdcas9611y7vdJcq2iYtM geZ6Po1hmKr4Zgp7xU040q50FWOmOT9J05rOAmuJiPoNuiZtrjmLFitHATO7DRMJ+M0O a4GKsO4Zv+NF8yMDp8VfdV/asG8isuYfEPDvlFAGRyIOpFmyAjn91UDysHyX4RMyhdXO AnKx7+fQC5kI4xUArtI37fFyOndzBbIGJWoSymQT2m4X6MqEXA7enRIrC/E85eOM9726 W5KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WwoHEE8hHryiGOd3Mhwepcll5gXefGpIh1T+3gwkYJA=; b=eB7yHoGlhvtOcD2ndMJzvAOFJSenfMdPoSQHGtDP+zTt3oRiS7EnsKL77l/cwXJ0AX CI1C38xsRTjpvKfBo+AF3TVC0HoH5JMyHRunCrYoWKBtCFHawMgJUgeedk41YnC2673U R1tbjXJWA3z3TBk5l1xM6ru3MEKbqdAcSvRsghGm7Q2dlCq2Eltxt/D+/6tsrpyrenOS c3fDRfkAhoXiGQif5F3r+0VXn+EE42kfLDwLPYyo+MbHDn25I2HmQ0dj8JXSPBMoCF/n 5ExmwBsIKHUP7YrsxmAWKDz8HExrIidJya5tsw/80IvmldkMHk6oknQMhA5YNxIrVXoR LARQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tqeE2euW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a1si14772194eds.169.2021.04.05.22.01.00; Mon, 05 Apr 2021 22:01:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tqeE2euW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232163AbhDEQuh (ORCPT + 99 others); Mon, 5 Apr 2021 12:50:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232191AbhDEQue (ORCPT ); Mon, 5 Apr 2021 12:50:34 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6CE0C061756 for ; Mon, 5 Apr 2021 09:50:27 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id u5-20020a7bcb050000b029010e9316b9d5so5909136wmj.2 for ; Mon, 05 Apr 2021 09:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WwoHEE8hHryiGOd3Mhwepcll5gXefGpIh1T+3gwkYJA=; b=tqeE2euWnKJ4LxJlLnz/7r0IDiJgQNlZJ8eVaQpBBXg6Z5IgffojYfxIylNdq7T1Wo rVaOqRm8or4A4D7eZK0iKtOKUMLl58Ky94xSJElTS2mUvLzmOv2v9yGg+ymW9YvtZcF9 lgzWzMPw2wPOUpRCw7fmUd2ArfEjyRAMWGKrXAC6qw82OMLhL2GDXH+hFPjnjmFaj/DT zTcIUxxk1oslxX3jt0xcc5kXF/GCtahv/STmYLKY1AirWn/dV4aOzXpyiJNSDQUmE1hR SxWEIA8aDkM5qUg+H+ImS7p8dyyGIphvTu3vohTIa8VDmDY70gNDAO9Gc34upTP6PDHr Aedw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WwoHEE8hHryiGOd3Mhwepcll5gXefGpIh1T+3gwkYJA=; b=D++CRkXWJe3p7JVOBXjtSQB2RGlUOUR6WrGC5jVDSvcIc4rYG/FOQIL6R7pjMwPV43 fNVhYQbTYfprUzGLc30tAmr7Uq3OhGWykR1iUpS9BETSizImk0CNf5fRWucSHDI7ikEy q3q68+HVrZca0siwcLeF0YsRSkD0XfOzfafPjKiXUY44GP33+bpWOYjfhN/QmiK658rJ Uz2nkwvDZbQOCDWvSjbx+Uy9CUPxQFSz2BfWeKnmyIff/e954sr3Ly24HGsF6WofEFPX 389ccf8Y0eDD484f46G+w+3KdvoUVYHCa+1+Sh0Xeunda24m6bHCbL+MK4kGEZKnb2nl dciA== X-Gm-Message-State: AOAM531KE2ZS2oUFnCgKJhRKAKVVW+LVv5qAl6+qdPrtZhpudtG+SfPt Wc+SZGMfK8Pyrn+TxMB5AUU= X-Received: by 2002:a05:600c:19d1:: with SMTP id u17mr26064wmq.141.1617641426524; Mon, 05 Apr 2021 09:50:26 -0700 (PDT) Received: from agape ([5.171.72.58]) by smtp.gmail.com with ESMTPSA id s8sm28366511wrn.97.2021.04.05.09.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Apr 2021 09:50:26 -0700 (PDT) From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: dan.carpenter@oracle.com, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Fabio Aiuto Subject: [PATCH 07/10] staging: rtl8723bs: place constant on the right side of the test Date: Mon, 5 Apr 2021 18:49:54 +0200 Message-Id: <8a6967abaef8b2edad6dc829dd232a7f048899d2.1617640221.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix following post-hook checkpatch issue: WARNING: Comparisons should place the constant on the right side of the test 85: FILE: drivers/staging/rtl8723bs/hal/sdio_halinit.c:676: + if (_FAIL == ret) Suggested-by: Joe Perches Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c index cec72abc983c..5553246fa80b 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -673,7 +673,7 @@ static u32 rtl8723bs_hal_init(struct adapter *padapter) /* rtw_hal_disable_interrupt(padapter); */ ret = _InitPowerOn_8723BS(padapter); - if (_FAIL == ret) + if (ret == _FAIL) return _FAIL; rtw_write8(padapter, REG_EARLY_MODE_CONTROL, 0); -- 2.20.1