Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3875544pxf; Tue, 6 Apr 2021 02:25:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeUlfrXKMAJEIqdCznTDNxu+pw9laA9Q7bXT7ZsUDJbHrJ6df56S+oYTdLJQS8oELiU4RO X-Received: by 2002:a05:6e02:b24:: with SMTP id e4mr18453889ilu.91.1617701149787; Tue, 06 Apr 2021 02:25:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617701149; cv=none; d=google.com; s=arc-20160816; b=XJUDggMynmDpgYNBF7mm6M/nmhWc79RwzwOq563YxzC0UiG0ImLxu2S4ytG8O80HkE 27zyW/FXkauo9e3vEWXaR4DqZ7vvcuWDpyIhTi0bUjayW2ZNkWQxKgRi+0EN1lvfBmxj 7Ba79+JHcCKwUmIe8K2Kmwo6s9gK/OCdhULPkB45Xl81NzCjj6KNkYnCXyYo1c+zlsk0 NROfkgYr26t0UPNSN5tUbzqqW+IBW+YPbzc2AhJtyJV3qM/ZjW+ABleg/mKcZFuIeo0N VGtoOvaThI/NxTnPrYBeFXglM25Df+27ZJyk3tgzd63PFXInULlmu4iDicoQg/woSTyT p/QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Th7mo+vc+gvliasVJy1K9tXrLo9RUNstWRPIZSS1pcE=; b=mwNTyWnONJ4OgiMURMdGRAJt93LlwmTHuK9E0PEUMP7veh9CnXAMz3XJWbe1fkibNF UIyd+sesVz0H1v1VLC8qlvkC6Kqm2iX+ovVNLaxn2Czc8h2IOgUC3O4DxA8T1maAfpgR bcv0gTfV1wmhSzIFn4ok5mAb7eaVemPRjkOABRdrmdpz0DUFTqndoHQdtLfU42+IhRQE K7yjPF+yg2U3esYtRmHfM/f428lGbWvf0IqVuu59YErhu0jYFkZfcoRIqfA6d1OXaPNs muc9AYZqdeTnpUEDsro4qDW9BNNmP1OlecUxF/q+Bvg/TWLfgpfWD/uhnJJac7Zz9dyC zFwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KihwHVZF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m3si16551685iol.17.2021.04.06.02.25.37; Tue, 06 Apr 2021 02:25:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KihwHVZF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236470AbhDEU3Q (ORCPT + 99 others); Mon, 5 Apr 2021 16:29:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234100AbhDEU3J (ORCPT ); Mon, 5 Apr 2021 16:29:09 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1055C061756 for ; Mon, 5 Apr 2021 13:29:01 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id h8so6232679plt.7 for ; Mon, 05 Apr 2021 13:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Th7mo+vc+gvliasVJy1K9tXrLo9RUNstWRPIZSS1pcE=; b=KihwHVZFW3sDrluFAhSe7CXCym6kBvL/NZnNocdsNQONk3FIExpDeTh6M8tv8ZMF9s aZqQE5md+oSNNS0HudUUmDKwQj/4pgjzg2m8hJAOzWbDp1n9in5b0YXdJWXTls0oApzv jnwTWevnSCSxYfmNWXsBuCy7Gqp1jAfp3s54w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Th7mo+vc+gvliasVJy1K9tXrLo9RUNstWRPIZSS1pcE=; b=Y+kXZMJcCo3lBFxwnSWb0hhWYYvfulr7n8U4jM5ljY2pTDltvoMakWE+9gWTPD/aUY +o1/4pKqgNYpACC4P4IsbZS22JSZY9HAVYcMmyXpEHxxIykkWkydWx50eb0b0M2HVGNo Js3dv4KKrW0QKBzV8wxvDLzOauWHxVjk44GOV9b3ohaY4ozP3J80hEOCqkqAsvt1KpJI eW7g8BBq0JNfSKsNjlVTf9bRn9AAvHEjkMO4pDvXssyfxb6p18Cf6euR8p0cmIseTqrj O/+70UojvicswqG6oYNTIOZxenMPN2ohrO/+4ZyL2ax6/66EOHAjfHfF9yYv/2ngJbk6 pj5g== X-Gm-Message-State: AOAM530NbAd5NmxpM0zwLSbj1C9BjVgoxLszNCPTuNaaksdAXrf1qvVy 2O0IWRExA1ndRjih2bmSCf8c2A== X-Received: by 2002:a17:902:b602:b029:e6:cabb:10b9 with SMTP id b2-20020a170902b602b02900e6cabb10b9mr25297590pls.47.1617654540797; Mon, 05 Apr 2021 13:29:00 -0700 (PDT) Received: from localhost ([2620:15c:202:201:2926:73d2:2f29:3222]) by smtp.gmail.com with UTF8SMTPSA id x22sm16091259pfa.24.2021.04.05.13.28.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Apr 2021 13:29:00 -0700 (PDT) From: Gwendal Grignou X-Google-Original-From: Gwendal Grignou To: bleung@chromium.org, enric.balletbo@collabora.com, groeck@chromium.org Cc: linux-kernel@vger.kernel.org, Gwendal Grignou Subject: [PATCH v2 0/2] platform/chrome: Update cros_ec sysfs attribute after sensors are found Date: Mon, 5 Apr 2021 13:28:55 -0700 Message-Id: <20210405202857.1265308-1-gwendal@google.com> X-Mailer: git-send-email 2.31.0.208.g409f899ff0-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Attribute "kb_wake_angle" in /sys//chromeos/cros_ec, used to set at which angle the embedded controller must wake up the host, is only set when there is at least 2 accelerometers in the chromebook. The detection of these sensors is done in cros_ec_sensorhub, driver that can be probed after the cros_ec_sysfs driver that sets the attribute. Therefore, we need to upgrade the cros_ec sysfs groups in the sensorhub probe routine. The first patch cleans up cros_ec_sysfs by using .dev_groups driver field, the second patch fixes the problem. Gwendal Grignou (2): platform/chrome: Use dev_groups to set device sysfs attributes platform/chrome: Update cros_ec sysfs attributes on sensors discovery drivers/platform/chrome/cros_ec_sensorhub.c | 5 ++++- drivers/platform/chrome/cros_ec_sysfs.c | 22 +++++++-------------- include/linux/platform_data/cros_ec_proto.h | 2 ++ 3 files changed, 13 insertions(+), 16 deletions(-) -- 2.31.0.208.g409f899ff0-goog