Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3892727pxf; Tue, 6 Apr 2021 02:59:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJsoXjrCvvD4J7cp71VWwe6BXpYIurucMzz9qh4WIQ7uB0v7pAyuE8T2et7VQo2AOSpqiS X-Received: by 2002:a50:a699:: with SMTP id e25mr12290372edc.276.1617703161598; Tue, 06 Apr 2021 02:59:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617703161; cv=none; d=google.com; s=arc-20160816; b=tAw4GyUYmcHy7og5YL/CZ+hNGwcMQskCyYnGCsixbo24HGX8pC9wvCXx2KezXthvHQ h0xXpvQVfxXXRli7m3/kSceUFUlRTYVRx6UbW0akjJJv2yqfHB4gO0Cl16cNCGGvjG7K FailHSOYhlyR3kuVdnzlCtdq0eZpjXUQq3UyaBc3gWSxIN7ZujBzMTb+twN5NFismKeH Fd/IOjZCqmuifqjmYakQGxRMJFeN0a+CDk7eVanzOJSDo67JKmJEnH1MVz0Q+S8unVNj OOolinlU54IuEWieX5l/wPjnFiCKi9TEvpOzs5fhHfor0v+T5QrmiwBKQwFdofubmETP YKnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=QQ/sz4QIHDjzJ8nBtshigsYBFNP5a7OC28YN9pA/Mgs=; b=EHxPi5wzlQakqanrX3aKnEpHBHiQ5zylWpdLBQipsXPdTU1vhqfA9WqHtvslVtIqc/ NKu7OkKvSAhT8vCcBSTi/9zlxwYO+ZP2SGVH2d70MY2XFVQdGo1e5ljK4kR+7Yqh/eDM Onlz7qK3J5UbvPIy+/1ll1i1cQ12LBKvnW2Kl/QHmgCAMu8kHKDUf4qzss3FNW1Wy3e+ eXM2mPNc1PyIAluUIECFcopyTHJLfn9eyu7f3iHoKiNHBMkLcntwItMk9TNQln+pPd7v 9Liy6FOc5ujgQRrcblp6JYirNzfcx/rZ8+nXK5hSr4HZ+q+0SWtu0bfRrzB3/gAYD32Y vjRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=pqY0VoiU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c21si16349518edt.47.2021.04.06.02.58.46; Tue, 06 Apr 2021 02:59:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=pqY0VoiU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241029AbhDEU4y (ORCPT + 99 others); Mon, 5 Apr 2021 16:56:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237443AbhDEU4x (ORCPT ); Mon, 5 Apr 2021 16:56:53 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C917FC061756; Mon, 5 Apr 2021 13:56:46 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id f8so9934803edd.11; Mon, 05 Apr 2021 13:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QQ/sz4QIHDjzJ8nBtshigsYBFNP5a7OC28YN9pA/Mgs=; b=pqY0VoiUuzbRQXs8ucTKXxClB62OzQM+BlbkkZ2Hye6SXe/syKCvG6pTuMLdaVubLl 5mgLqR8fESyG3no3UFkaTx1QNBSPOiD3mpwRa6Tyia2y19PsRP2Kg0dccNPZzXp1vh1h QT3K4XtgNf1kTxFvziOT/8W9P3N1PdcHhUuqGvbq8F7dH2rhg/34XVPlgCXN3CydNaM9 kKHHfKXjwg5HVDkEjBvrd/lutrJglYGOecJlYhiruWYFyhGnet76U46FxPZH5q2xvFLy aO7xfTHcQHF0FvHGQjJSbyyoSy+vy7q0SMFhXl4o/qLIiAy2zvfHxpW7iq+jB1hPq2xO EvSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QQ/sz4QIHDjzJ8nBtshigsYBFNP5a7OC28YN9pA/Mgs=; b=YUNT9uvdbHaBFZUpjCS+bsRqA/FBo7bq5WspaVmKaEWTdQtCsbny9u8SgSvwwLWoTz Au4urQ9ooa6MF02Wk7m5Yq+oc1A/hOQxfx3X1rmMhQjG/++Z/cna9PBC4qpq2WSR3tEU d4863KqAcdMBFn47Y8qh0t42F0uh6iyMnDi1kvkgWtfvP2fl9+AM9+Y4h0P8J2PhdYUl 1+33PDnnV2GSBIJlLo0/YfXS8tCLbq8LPyzEc6tgu8/ayDWzVjZCzpG1mjxqxlgnKiR/ tmx5yfhA54frMN40bn0HtP+ETBQ3Sj9fKawFWa4MI+awh65jID8j3Gt9EbC4r2uiWUqY nXKw== X-Gm-Message-State: AOAM533oUZL8FW1j5vejp8Di4hjIM7WyaPUpi7L6ZcSKYniWRTX368Dj IABLz9GMjWiAzXHdy6/mu5BgVjDACo04ocuTpdY= X-Received: by 2002:a05:6402:1713:: with SMTP id y19mr33533620edu.52.1617656205602; Mon, 05 Apr 2021 13:56:45 -0700 (PDT) MIME-Version: 1.0 References: <20210329161256.31171-1-christianshewitt@gmail.com> <20210329161256.31171-3-christianshewitt@gmail.com> In-Reply-To: <20210329161256.31171-3-christianshewitt@gmail.com> From: Martin Blumenstingl Date: Mon, 5 Apr 2021 22:56:34 +0200 Message-ID: Subject: Re: [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+ To: Christian Hewitt Cc: Rob Herring , Mark Rutland , Kevin Hilman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Hyeonki Hong Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 30, 2021 at 1:18 AM Christian Hewitt wrote: > > From: Hyeonki Hong > > Add the meson saradc node to the ODROID N2/N2+ common dtsi. in general I am fine with this as some SAR ADC channels seem to be on the pin headers... [...] > +&saradc { > + status = "okay"; > +}; ...but a vref-supply should be provided to get meaningful numbers