Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3904417pxf; Tue, 6 Apr 2021 03:17:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLmw7seDJoNAhZGKbc9jlCZQdJ9a0fK8c0cZo9OurAudBYabWDQYhx/Sua/xir2SpkiQ/U X-Received: by 2002:a17:906:b341:: with SMTP id cd1mr32941404ejb.391.1617704252525; Tue, 06 Apr 2021 03:17:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617704252; cv=none; d=google.com; s=arc-20160816; b=Bret27Hj3i6EkQfs+LJoMsPNgyMBh+OvhLoHlhVGhMK47CvZr5KMYWkK18k2xzCnVh 86iy3atU2g9YP3A+k/r7Bk1XswWiFAkKJ+xNxO16e1W0lx6M9oMArGp50RVnTaCvDNol YJwuuldSYx2nEHIMhoWxQY4OapTyGlXHBdF2xsNRac/nvN0ZFkjiNbHm93CEjJkjkNEW 4VbH2F2nBPqPudDywh7eEDaaPvHluCKZ8saeUH2dkk0xRef9Hj3qgc6c82J3+tMjhBKO ie1IoftqwMgWUw26hYoCsfd97NSYsOe2SClN0BRegI3D0JfbJfBuOaiM/cRi78zt2AtD Mifg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=DceUy+2NUnlC8ur/URFEkVm8PqULS5zh5pj+vzZYRL4=; b=UFDITYDge5Ps13oP9NIA6RWEdmy690HEYqKV7Rm97Ngctr8D0TY+4i2umFf518NXon aHFD4ucVIZAfVNOZQ6cKI6T+TWEYl2L7jo/2rSbLuCPcyjg8OyYYgnAmLsH8TCYtPsrC Mi/+DuxbVFOeYfjCpYuRwHpCeSmgUA+o41YYeOedbt+hQZCe/g+Gy7LmgJm+kjhOSTgm R8pe2hrsSFQbHAvV8UOuueuhiEVSj8mn2irXC/KUMGtYpHlrWtrKfHNRQJ+MMLOTC+8e ELl7/isQ6m8gi70vwaPxP0cEutjoxBD/dXoTJKpHThDpJwHIvHGQ82m795SXDOxB8KxN 0myQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kemnade.info header.s=20180802 header.b=U0kZ9bQ7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i6si16189072edu.313.2021.04.06.03.17.08; Tue, 06 Apr 2021 03:17:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kemnade.info header.s=20180802 header.b=U0kZ9bQ7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237637AbhDEWQi (ORCPT + 99 others); Mon, 5 Apr 2021 18:16:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236135AbhDEWQh (ORCPT ); Mon, 5 Apr 2021 18:16:37 -0400 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a01:238:4321:8900:456f:ecd6:43e:202c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05001C061756 for ; Mon, 5 Apr 2021 15:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DceUy+2NUnlC8ur/URFEkVm8PqULS5zh5pj+vzZYRL4=; b=U0kZ9bQ7SmB9OarOU1kip/YGbo 1WwN48ETUBqjEmaghnpJ2dZVC53HTCtUIOLlqzsc5HnR6U8cT6RmAGc/1UjQXxAB9/DUeGrgsZtrr ImbvaEtSoxHj0kDIQbl8IzB+OWHt4mr3fGNWtXykIfpGquDw3XGgm1+p+jrjWllT8OFA=; Received: from p200300ccff0b410002133bfffe9baf32.dip0.t-ipconnect.de ([2003:cc:ff0b:4100:213:3bff:fe9b:af32] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1lTXWF-0002sy-EY; Tue, 06 Apr 2021 00:16:27 +0200 Received: from andi by aktux with local (Exim 4.92) (envelope-from ) id 1lTXWF-0007q1-3t; Tue, 06 Apr 2021 00:16:27 +0200 From: Andreas Kemnade To: lee.jones@linaro.org, andreas@kemnade.info, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org Subject: [PATCH] mfd: rn5t618: fix IRQ trigger by changing it to level mode Date: Tue, 6 Apr 2021 00:15:58 +0200 Message-Id: <20210405221558.30046-1-andreas@kemnade.info> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During more massive generation of interrupts, the IRQ got stuck, and the subdevices did not see any new interrupts. That happens especially at wonky USB supply in combination with ADC reads. To fix that trigger the IRQ at level low instead of falling edge. Fixes: 0c81604516af ("mfd: rn5t618: Add IRQ support") Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c index ecddd7b6500e..a852eef1f4d2 100644 --- a/drivers/mfd/rn5t618.c +++ b/drivers/mfd/rn5t618.c @@ -109,7 +109,7 @@ static int rn5t618_irq_init(struct rn5t618 *rn5t618) ret = devm_regmap_add_irq_chip(rn5t618->dev, rn5t618->regmap, rn5t618->irq, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + IRQF_TRIGGER_LOW | IRQF_ONESHOT, 0, irq_chip, &rn5t618->irq_data); if (ret) dev_err(rn5t618->dev, "Failed to register IRQ chip\n"); -- 2.29.2