Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] power: supply: Add battery driver for Surface
 Aggregator Module
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Hans de Goede <hdegoede@redhat.com>, linux-pm@vger.kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210309000530.2165752-1-luzmaximilian@gmail.com>
 <20210309000530.2165752-2-luzmaximilian@gmail.com>
 <20210405153752.2r4ii5lguogchgl4@earth.universe>
 <046f6149-55fd-431e-d582-cc5915d10e20@gmail.com>
 <20210405213241.r6xhtbaf4qkzylz2@earth.universe>
From:   Maximilian Luz <luzmaximilian@gmail.com>
Message-ID: <5e6692b9-d043-8a18-8d76-afb235caddbb@gmail.com>
Date:   Tue, 6 Apr 2021 00:34:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210405213241.r6xhtbaf4qkzylz2@earth.universe>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 4/5/21 11:32 PM, Sebastian Reichel wrote:
> [...]
>>>> +static void spwr_battery_unregister(struct spwr_battery_device *bat)
>>>> +{
>>>> +	ssam_notifier_unregister(bat->sdev->ctrl, &bat->notif);
>>>> +	cancel_delayed_work_sync(&bat->update_work);
>>>> +	device_remove_file(&bat->psy->dev, &alarm_attr);
>>>> +	power_supply_unregister(bat->psy);
>>>
>>> power_supply_unregister being the last function call is a clear
>>> sign, that devm_power_supply_register can be used instead.
>>
>> Right, that works here. I normally try to not mix devm code with
>> non-devm code (apart from maybe allocations).
> 
> well allocations are usually done first and free'd last making
> them the first targets in the conversion and pretty much a no
> brainer.
> 
> Next merge window it's possible to easily go to full devm by
> using devm_delayed_work_autocancel(), which has been merged
> by Greg two weeks ago. Then last but not least do the ssam
> notifier unregister via devm_add_action_or_reset and its fully
> converted :)

Neat, I'll have a look at maybe adding some devm versions for the
SSAM notifiers. Should help in at least one other driver apart from
these two.

Thanks,
Max