Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3983298pxf; Tue, 6 Apr 2021 05:22:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEbs4PwJMG1FogGD5hGsgUU+0waIRTiVGUn94ei6jQ4p34MBHXjxYHyggO5zQGFZrykmgX X-Received: by 2002:a5e:dd09:: with SMTP id t9mr22902603iop.111.1617711779225; Tue, 06 Apr 2021 05:22:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617711779; cv=none; d=google.com; s=arc-20160816; b=MQ2gpfwJbQJoplyX6Y8Jap9TpxAOfhPLkSjbg5WFq+P12KR8cyzG4MCr8MG7RJ2OdS 3tZum85ZB0V8S0tNAHVcWF/2aYC3GMiUlAOH157emqh7kitt4mnBxJS7HrvynNEc55FN S2BYX3J2NmqBez2t4Wn7vf2DUzKBJdpYhrBZSwHnkRMlKxfom3gLC+i3t9KPdA53WBuR BJt3904OPr8CMbBqHYRchjN+K+sYgNIxVVnww6TAYr059DLxJ0Dj8udI+W8GhfSGpdwb 0Vz1oeMNhhFpf+9oAghIAVFS8gErvucV5jLFfZea4UeKuH3+Pepta4InDrXLdpFzmdyp vaFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:ironport-sdr :ironport-sdr; bh=+P1v18zlEhwBwSgdbdo5yebX+w23vLU1abbI7eSSU/0=; b=HQBTTj9SvBAQj25xU2/dTSaDUGp2KURT+ZMaGEJDh4rx2nvIvtpD3qKbzAmEy9xdEQ YMRjGKLLA4H2DfpzKPuFvS1+aH+6mavqfsGqSH1SICVCO5yx0Lf/lDr8Iqkc6SPI1GJS iXK0/+B2w5JoOijPgVcFz464ntsVGipQCm/pGXnRs3K7cGQDD6xGL7m3hwhoMtqBz6vy HY5xXwyARhy+VbZ2C3fpGjsSw7ykRK7vTxrxG8bnHE1+pn3kpA0NAFmXNhvzABo3H/Gv dJWvK2qCDoo06MiBXMVn2CWba5nY2tVLcdn6FvBcsq4SyCpXVBzXhd5b6+ZEeEW6gg5Z haYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n9si17155480ilt.121.2021.04.06.05.22.46; Tue, 06 Apr 2021 05:22:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243108AbhDFBdC (ORCPT + 99 others); Mon, 5 Apr 2021 21:33:02 -0400 Received: from mga04.intel.com ([192.55.52.120]:56585 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230476AbhDFBdB (ORCPT ); Mon, 5 Apr 2021 21:33:01 -0400 IronPort-SDR: 3DWO5Cjo5ewOoJxxS0uoFuFZbR/uuLM47lLUAUPQU3alOvEgZTMbVBsHKAVRr9swyDBBGUTQ6q u8KOpg3qWq7w== X-IronPort-AV: E=McAfee;i="6000,8403,9945"; a="190783678" X-IronPort-AV: E=Sophos;i="5.81,308,1610438400"; d="scan'208";a="190783678" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2021 18:32:54 -0700 IronPort-SDR: vYV/ERUKjRELAc4zoPuduFJq5T14mSjVDqQZgV0QGCcjyPllKdU0rV2ml1qTH17HyV+P6RLEDV GX5R44VEdEYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,308,1610438400"; d="scan'208";a="609081809" Received: from climb.png.intel.com ([10.221.118.165]) by fmsmga006.fm.intel.com with ESMTP; 05 Apr 2021 18:32:51 -0700 From: Voon Weifeng To: "David S . Miller" , Maxime Coquelin Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jose Abreu , Jakub Kicinski , Giuseppe Cavallaro , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Ong Boon Leong , Voon Weifeng , Wong Vee Khee Subject: [PATCH v2 net-next] stmmac: intel: Enable SERDES PHY rx clk for PSE Date: Tue, 6 Apr 2021 09:32:50 +0800 Message-Id: <20210406013250.17171-1-weifeng.voon@intel.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org EHL PSE SGMII mode requires to ungate the SERDES PHY rx clk for power up sequence and vice versa. Signed-off-by: Voon Weifeng --- Changes: v1 -> v2 -change subject from "net: intel" to "stmmac: intel" --- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 10 ++++++++++ drivers/net/ethernet/stmicro/stmmac/dwmac-intel.h | 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c index add95e20548d..a4fec5fe0779 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c @@ -153,6 +153,11 @@ static int intel_serdes_powerup(struct net_device *ndev, void *priv_data) return data; } + /* PSE only - ungate SGMII PHY Rx Clock */ + if (intel_priv->is_pse) + mdiobus_modify(priv->mii, serdes_phy_addr, SERDES_GCR0, + 0, SERDES_PHY_RX_CLK); + return 0; } @@ -168,6 +173,11 @@ static void intel_serdes_powerdown(struct net_device *ndev, void *intel_data) serdes_phy_addr = intel_priv->mdio_adhoc_addr; + /* PSE only - gate SGMII PHY Rx Clock */ + if (intel_priv->is_pse) + mdiobus_modify(priv->mii, serdes_phy_addr, SERDES_GCR0, + SERDES_PHY_RX_CLK, 0); + /* move power state to P3 */ data = mdiobus_read(priv->mii, serdes_phy_addr, SERDES_GCR0); diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.h b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.h index e723096c0b15..542acb8ce467 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.h +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.h @@ -14,6 +14,7 @@ /* SERDES defines */ #define SERDES_PLL_CLK BIT(0) /* PLL clk valid signal */ +#define SERDES_PHY_RX_CLK BIT(1) /* PSE SGMII PHY rx clk */ #define SERDES_RST BIT(2) /* Serdes Reset */ #define SERDES_PWR_ST_MASK GENMASK(6, 4) /* Serdes Power state*/ #define SERDES_PWR_ST_SHIFT 4 -- 2.17.1