Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 06 Apr 2021 09:22:29 +0100
Message-ID: <87o8erq0u2.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>
Cc:     suzuki.poulose@arm.com, anshuman.khandual@arm.com,
        gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [GIT PULL] coresight: Add support for ETE and TRBE
In-Reply-To: <20210405191757.283122-1-mathieu.poirier@linaro.org>
References: <20210405191757.283122-1-mathieu.poirier@linaro.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

Hi Mathieu,

On Mon, 05 Apr 2021 20:17:57 +0100,
Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
> 
> The following changes since commit a354a64d91eec3e0f8ef0eed575b480fd75b999c:
> 
>   KVM: arm64: Disable guest access to trace filter controls (2021-03-24 17:26:38 +0000)
> 
> are available in the Git repository at:
> 
>   git@gitolite.kernel.org:pub/scm/linux/kernel/git/coresight/linux.git next-ETE-TRBE
> 
> for you to fetch changes up to 7885b4e43231048654c5a80c0a18844ce3185e64:
> 
>   dts: bindings: Document device tree bindings for Arm TRBE (2021-04-05 11:38:04 -0600)
> 
> ----------------------------------------------------------------
> Hi Marc,
> 
> As previously agreed, here are the changes to support CoreSight
> ETE and TRBE components submitted here[1].
> 
> I draw your attention to these:
> 
> [PATCH v6 05/20] kvm: arm64: Handle access to TRFCR_EL1
> [PATCH v6 06/20] kvm: arm64: Move SPE availability check to VCPU load
> [PATCH v6 07/20] arm64: kvm: Enable access to TRBE support for host
> 
> They are KVM specific and will need an SoB tag.

There seem to be a disconnect here, because it works the other way
around.

If I pull this, I obviously cannot add anything to the patches that
are merged (changing stuff would result in changing the commit IDs,
which is exactly the opposite of what we are trying to achieve).

This isn't a problem, as the act of pulling the branch means that I am
happy with that, and the git merge makes it traceable.

However, some of the patches (the KVM ones) do not carry your own SoB,
which is a problem (if you are picking stuff off the list, you need to
add your own SoB). So for the couple of KVM patches, please add my

	Acked-by: Marc Zyngier <maz@kernel.org>

together with your SoB, resend the PR and I'll gladly merge it.

And if you can make sure the subject lines are formatted as:

	"KVM: arm64: Super Duper feature enablement"

that'd be absolutely awesome (but that's just me being annoying...).

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.