Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] serial: 8250: Make symbol 'brcmuart_debugfs_root'
 static
To:     Zucheng Zheng <zhengzucheng@huawei.com>, alcooperx@gmail.com,
        gregkh@linuxfoundation.org
Cc:     linux-serial@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com,
        linux-kernel@vger.kernel.org, hucool.lihua@huawei.com
References: <20210401074919.56573-1-zhengzucheng@huawei.com>
From:   Jiri Slaby <jirislaby@kernel.org>
Message-ID: <7d91eb53-cde3-934c-a75f-833f98e6b156@kernel.org>
Date:   Tue, 6 Apr 2021 06:53:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210401074919.56573-1-zhengzucheng@huawei.com>
Content-Type: text/plain; charset=iso-8859-2; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01. 04. 21, 9:49, Zucheng Zheng wrote:
> symbol 'brcmuart_debugfs_root' is not used outside of 8250_bcm7271.c,
> so this commit marks it static.
> 
> Signed-off-by: Zucheng Zheng <zhengzucheng@huawei.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> ---
>   drivers/tty/serial/8250/8250_bcm7271.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
> index 63883185fccd..ebba7f2e960c 100644
> --- a/drivers/tty/serial/8250/8250_bcm7271.c
> +++ b/drivers/tty/serial/8250/8250_bcm7271.c
> @@ -239,7 +239,7 @@ struct brcmuart_priv {
>   	u32		rx_abort;
>   };
>   
> -struct dentry *brcmuart_debugfs_root;
> +static struct dentry *brcmuart_debugfs_root;
>   
>   /*
>    * Register access routines
> 


-- 
js