Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4128377pxf; Tue, 6 Apr 2021 08:32:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCdQkYHkBS44SZRDjkpRUJX8QkeU2jRg19Lo16DdgrfAHtiOCJtfbJIUu59K/D+rLVb5wH X-Received: by 2002:a05:6402:1cc1:: with SMTP id ds1mr29657544edb.135.1617723159422; Tue, 06 Apr 2021 08:32:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617723159; cv=none; d=google.com; s=arc-20160816; b=RXNjvo1CaE9Kri7yyjPWeNkk/7uKRI9w1l1WVbHhGehC3SAUNC97I7FuXm8Fr3ETev tnuz4+8VsQuydTdgPp1I5qckcWCxmZrrry2qqoZrGXL3ElHxgg6EsCvCFVsWwm8b49oA 9GWYnGEJF5a170eSLPQkZY7ykq9m3iQ59BJdLOEiE20+bjg06ER8bLjA1P6WxAEHqDxA Tu+si81VqrswSki/xqKmm9zSznp5uIEByFAy+KEpUrsa7D7A7xkb0oMs4Yr2gTsrfvZI yBMvCdpFyeG+sev/J/q9sMTeTUJJI2HjDWMB2J8F3PyqMH1OeMX1PlN0HIKLSCT+bhrF PYxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/+MYJd3LxTp4Htmsbg7tBW6nxS0/C4h+q7AfC+PQJI8=; b=nVvfW5nQmVjOu9JFcyVI5mtcvrnV2HKf0HfO0pCzvN4yb5NwQ1hqo9Mzke4gN8H1nt VN2k513Mj83LCJCITPMR+7xwi9Cxiqd3A4WlBaRnQB7DS2NylO/IE7Gk6bK5cqiWQIhe bewyzSxUJm99VliJyIXH5VfKbl74tIVZCNtvtoN7PS2elnH6AO5JdvBJ2D//tp4YKZez ijJeXveQgv9tFA8Fx6Bk0yiBSYERGo4sz3NW5xvnMLxMhaXcZ7lZHLAsToGZjUVKL0D8 7qHzUlW9I8k0t4jI6MpJx/VYSWxpCXY9OmjNorShZO/Q3igoVeLv1cCM2zuJKhGwRzlr kEQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Z7GuahCg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l10si16939537edb.348.2021.04.06.08.32.15; Tue, 06 Apr 2021 08:32:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Z7GuahCg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232921AbhDFFJV (ORCPT + 99 others); Tue, 6 Apr 2021 01:09:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:57650 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230073AbhDFFJU (ORCPT ); Tue, 6 Apr 2021 01:09:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7D7AA6139B; Tue, 6 Apr 2021 05:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1617685753; bh=LqjMrJSAzijL431bshxV0LVdpKWP5C/U0bzpPFaPPKM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Z7GuahCgW+CfUDeOOiNubLpgrAQ3l1kD+SezHa02EE9DOzaNePYWlKhma+tQgyVUO tLLL+UjyJmH2I332r0yAHP1gLOuX2Bph6HZUxL7oQx8GWYwGMz1B5ok65TV16U8QAn LTBVbH+SuwqMGYXLaew+LpY2I6bkmWY13axbHpyI= Date: Mon, 5 Apr 2021 22:09:12 -0700 From: Andrew Morton To: Davidlohr Bueso Cc: jbaron@akamai.com, rpenyaev@suse.de, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH 2/2] fs/epoll: restore waking from ep_done_scan() Message-Id: <20210405220912.b916e5f504cd2c11d7288cb2@linux-foundation.org> In-Reply-To: <20210406032226.2fpfzrlyxu2wz2jw@offworld> References: <20210405231025.33829-1-dave@stgolabs.net> <20210405231025.33829-3-dave@stgolabs.net> <20210405185018.40d437d392863f743131fcda@linux-foundation.org> <20210406032226.2fpfzrlyxu2wz2jw@offworld> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Apr 2021 20:22:26 -0700 Davidlohr Bueso wrote: > On Mon, 05 Apr 2021, Andrew Morton wrote: > > >Tricky. 339ddb53d373 was merged in December 2019. So do we backport > >this fix? Could any userspace code be depending upon the > >post-339ddb53d373 behavior? > > As with previous trouble caused by this commit, I vote for restoring the behavior > backporting the fix, basically the equivalent of adding (which was my intention): > > Fixes: 339ddb53d373 ("fs/epoll: remove unnecessary wakeups of nested epoll") OK, I added the Fixes: line and the cc:stable line.