Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4128777pxf; Tue, 6 Apr 2021 08:33:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/67pAZdLfzDLMPQV6oiu2AbZuwzE26E22C5aa8R/laH3SIWYiupP2uCdHrsni9+LeDVqY X-Received: by 2002:adf:e38a:: with SMTP id e10mr36012086wrm.37.1617723187349; Tue, 06 Apr 2021 08:33:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617723187; cv=none; d=google.com; s=arc-20160816; b=JV6gVZIs/K77cpuXJEmaO0Mj/R1Hqf8pc2QMvoiUsZAdwPcxH5eaOQFQMjGIBz0QUw WqX37e7h5VJ/OWgy7e9oXOYJERMw9ySGTAqU52NFLFFFwxbYoJQefg3qE05Zzx4KowFZ hJ6R0GfyO2nYmtQrFOUjZE8Wjj4Fp3WVAEtBUoegeCS06siTP/hIR+X/uqGcwBBAn31F A2IXKlsIfSOVnJNXEgLEGO8I6x9E9TGloQdxigL0ifSjpLg79IVT9tOSo3lYzBnxB1Qo i2t58ETTD1sy9g+kF0mnjoIN2sTb6pICi0fYlwnAt3/87JdmfCTHbuK27A55mAtrbDBG RVdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=H+DHLHYoMSXcfd81bKz2k8Vu1qa6GwFtcChFDQyn67c=; b=071o6F2dRpve7zT/xjKAd9PEPtD0YQmkXcxj8QCdC66UrMa90y6LpJy/5LOUf5M+FX haVeHLKu2OCVBXZOwHid6FxkN1R6Mdsfj5y1Ir1A7ZYSCzCTfpahOXh9LID4/7hY2lQ0 m6ojsRC+7SZoDxpXeP8rs0DdtZBXf4NShudc/tsVsE302YiGjnCFM05Hm08xTKATooKm hjN+bzjQX3Q8tS4zV1JvdndKTEjRCIPfPkHEbOjmimBzSYy4TS7WmFh5VEdtL6ZP9lFo wOj35z8ZiVv9DQgcV4RY0p0+sYgE8xOFX+L+QsMSeIHFRsdsFW83ruMiGJNiUbiVrq6z zMSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TXS6ap2H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h12si18334633edj.156.2021.04.06.08.32.43; Tue, 06 Apr 2021 08:33:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TXS6ap2H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239669AbhDFF0g (ORCPT + 99 others); Tue, 6 Apr 2021 01:26:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:33134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232874AbhDFF0g (ORCPT ); Tue, 6 Apr 2021 01:26:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3B57561246; Tue, 6 Apr 2021 05:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617686788; bh=SmVeK0AzoGvnM/oVSClhxdFpdRkFXOYQtTI6gWclCvc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TXS6ap2HESrw9shecjMTxGQh5jxSPKvPO+smESiwctRKnpV6WpvNKWmq9PTc+mk/h nbGKTFYFDGNzK54Ul6+wmLHt3nq4UiWnJhtHAThCjhM6hbXgJtGy1kl149R1GHRDeq jqf9KKj1Hn0ZsLFZbObhdvHkgNv85iVxQGuQ4gU4= Date: Tue, 6 Apr 2021 07:26:26 +0200 From: Greg KH To: Jiapeng Chong Cc: balbi@kernel.org, joel@jms.id.au, andrew@aj.id.au, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: aspeed: Remove unnecessary version.h includes Message-ID: References: <1617681598-28165-1-git-send-email-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617681598-28165-1-git-send-email-jiapeng.chong@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 06, 2021 at 11:59:58AM +0800, Jiapeng Chong wrote: > "make versioncheck" shows: > > ./drivers/usb/gadget/udc/aspeed-vhub/hub.c: 33 linux/version.h not > needed. Then you need to fix the tool, and always test-build patches before you send them out, as this is obviously wrong :(