Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements
 of condition.
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20210404132613.5464-1-dev.dragon@bk.ru>
 <YGrjKEjr9GJtJlO5@kroah.com>
From:   "dev.dragon" <dev.dragon@bk.ru>
Message-ID: <4cba0693-2dd1-4a90-b6de-509910593d87@bk.ru>
Date:   Tue, 6 Apr 2021 08:35:37 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <YGrjKEjr9GJtJlO5@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/5/21 1:15 PM, Greg KH wrote:
> On Sun, Apr 04, 2021 at 04:26:14PM +0300, dev.dragon@bk.ru wrote:
>> From: Dmitrii Wolf <dev.dragon@bk.ru>
>>
>> Fixed a coding style issue.
> 
> Really?
> 
>>
>> Signed-off-by: Dmitrii Wolf <dev.dragon@bk.ru>
>> ---
>>  drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
>> index 690b664df8fa..29a6ce20e2bd 100644
>> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
>> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
>> @@ -2048,12 +2048,12 @@ void ieee80211_softmac_xmit(struct ieee80211_txb *txb, struct ieee80211_device *
>>  	/* if xmit available, just xmit it immediately, else just insert it to the wait queue */
>>  	for (i = 0; i < txb->nr_frags; i++) {
>>  #ifdef USB_TX_DRIVER_AGGREGATION_ENABLE
>> -		if ((skb_queue_len(&ieee->skb_drv_aggQ[queue_index]) != 0) ||
>> +		if ((skb_queue_len(&ieee->skb_drv_aggQ[queue_index]) != 0)
>>  #else
>> -		if ((skb_queue_len(&ieee->skb_waitQ[queue_index]) != 0) ||
>> +		if ((skb_queue_len(&ieee->skb_waitQ[queue_index]) != 0)
>>  #endif
>> -		    (!ieee->check_nic_enough_desc(ieee->dev, queue_index)) || \
>> -		    (ieee->queue_stop)) {
>> +		 || (!ieee->check_nic_enough_desc(ieee->dev, queue_index)) \
>> +		 || (ieee->queue_stop)) {
> 
> This feels really wrong.
Reread coding style - agree with you.
> 
> The || should be on the end of the line, why is checkpatch complaining
> about this?
Looks like it was confused by preprocessor directives - excluding it by comments gave me positive checkpatch respond.
> 
> And that '\' is not needed at all :(
Can i fix it in my next patch?:)
> 
> thanks,
> 
> greg k-h
>