Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] integrity/ima: Add declarations to init_once void
 arguments.
To:     Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc:     linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, james Morris <jmorris@namei.org>
References: <20210323013318.296993-1-unclexiaole@gmail.com>
 <f97e397d-5d9f-31c3-c027-d9b89ba9637a@gmail.com>
 <c6fd4033-f4bb-40d2-9bd-c3f2d92c3a2a@namei.org>
From:   Jiele Zhao <unclexiaole@gmail.com>
Message-ID: <5bb74c3e-c91c-f070-7f8b-907b148cb958@gmail.com>
Date:   Tue, 6 Apr 2021 14:24:33 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <c6fd4033-f4bb-40d2-9bd-c3f2d92c3a2a@namei.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Mimi,

Please see if this is a useful suggestion.

On 2021/4/6 10:38, James Morris wrote:
> On Tue, 6 Apr 2021, Jiele Zhao wrote:
>
>> Ping.
> Mimi Zohar is the maintainer for this code.
>
>> On 2021/3/23 9:33, Jiele Zhao wrote:
>>> init_once is a callback to kmem_cache_create. The parameter
>>> type of this function is void *, so it's better to give a
>>> explicit cast here.
>>>
>>> Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>
>>> ---
>>>    security/integrity/iint.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
>>> index 1d20003243c3..5f3f2de997e1 100644
>>> --- a/security/integrity/iint.c
>>> +++ b/security/integrity/iint.c
>>> @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
>>>    
>>>    static void init_once(void *foo)
>>>    {
>>> -	struct integrity_iint_cache *iint = foo;
>>> +	struct integrity_iint_cache *iint = (struct integrity_iint_cache
>>> *)foo;
>>>    
>>>     memset(iint, 0, sizeof(*iint));
>>>     iint->ima_file_status = INTEGRITY_UNKNOWN;