Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 2/2] scsi: pm8001: clean up for open brace
To:     Bart Van Assche <bvanassche@acm.org>, <jinpu.wang@cloud.ionos.com>,
        <jejb@linux.ibm.com>, <martin.petersen@oracle.com>
CC:     <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>
References: <1617354522-17113-1-git-send-email-luojiaxing@huawei.com>
 <1617354522-17113-3-git-send-email-luojiaxing@huawei.com>
 <614f4c0f-deaa-ad3a-09d1-ac6e8ec2d143@acm.org>
From:   luojiaxing <luojiaxing@huawei.com>
Message-ID: <400a9958-dffc-7e09-6bbb-33666c991415@huawei.com>
Date:   Tue, 6 Apr 2021 14:40:01 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <614f4c0f-deaa-ad3a-09d1-ac6e8ec2d143@acm.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2021/4/3 0:03, Bart Van Assche wrote:
> On 4/2/21 2:08 AM, Luo Jiaxing wrote:
>> -static struct flash_command flash_command_table[] =
>> -{
>> +static struct flash_command flash_command_table[] = {
>>        {"set_nvmd",    FLASH_CMD_SET_NVMD},
>>        {"update",      FLASH_CMD_UPDATE},
>>        {"",            FLASH_CMD_NONE} /* Last entry should be NULL. */
> Can 'flash_command_table' be declared const?


Sure


>
>> -static struct error_fw flash_error_table[] =
>> -{
>> +static struct error_fw flash_error_table[] = {
>>        {"Failed to open fw image file",	FAIL_OPEN_BIOS_FILE},
>>        {"image header mismatch",		FLASH_UPDATE_HDR_ERR},
>>        {"image offset mismatch",		FLASH_UPDATE_OFFSET_ERR},
> Can 'flash_error_table' be declared const?


Sure


Thanks

Jiaxing


>
> Thanks,
>
> Bart.
>
> .
>