Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4220540pxf; Tue, 6 Apr 2021 10:43:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLK03EGll59qJ5UvAsseVe91NC6ipSX9lBG1pgHb8A9daNuDQ+jNRMccgDvyXHX+48SKqi X-Received: by 2002:a6b:ec08:: with SMTP id c8mr23580014ioh.55.1617730994065; Tue, 06 Apr 2021 10:43:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617730994; cv=none; d=google.com; s=arc-20160816; b=l3NEeO+kAFUNTReokPqDdsx5TqGen7PlblrxqRx2lN9Kgo9KbXpYFs5zPUlJP5q0Dc vYfX1piayB8Iki4qc0sSZga8objLGZVlto4zip1a5lomJgbidwBAoa9MgXA9cpiIq11l 9hD03efH7hqEgBgBjEg1LQMohCOC1n7h9NEh/YZA4pB2YyCFjtEO++P2b6/kKX+TknVH HreknF/7iC2IQ+xeKjRjF+x8RaK0hJetzOv8grCAV1ldUysEU8ldhZ/s1+Egw2NEFm8y jOBK/NC3qEVLEdJHV2dha4q+hTkoaYvSgfKQGwvIfz9FmOZ6Bj/yn2jtnXb1v6acsnVT loaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=1JQdbiX3V2S6KjGup3X4IdcaUQPxd8uPQRRMIeOHJbs=; b=C6gC5v3/+bs5gGMPlKrLDTBlk/Cn8fg+/uMqgglPHT7bnuAbP+cFJO+tEOYKV/mAz5 gFv7oThvFnfedg6AsUOZzGf6pIxRpdsQR5k7mj1YDvtUUwjv9r+W9GgSiAaD5CQKMHcw vjSGrFNktVtEPheTYgNWA2I5F+nJ1SCc2SY51iVZIsOy8ownohfMj4scZQeL62zqlghU B6pRZSgmeKGcM/pjkJpSukutZu16ZJQXcBXF1W1Upkb4z9wC7hUFCWB2HMWh2WUo0rPT mF2lhwxGLv4OCn308xW2eggwaLHtUs6N63LPm4ak0pc7zx0lbbjOvQjyJU/a9yNg1usD H1xA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s16si17854516iog.103.2021.04.06.10.43.00; Tue, 06 Apr 2021 10:43:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234330AbhDFJ34 (ORCPT + 99 others); Tue, 6 Apr 2021 05:29:56 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:16347 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbhDFJ34 (ORCPT ); Tue, 6 Apr 2021 05:29:56 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FF2HY0s17z9wsQ; Tue, 6 Apr 2021 17:27:37 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.208) with Microsoft SMTP Server (TLS) id 14.3.498.0; Tue, 6 Apr 2021 17:29:46 +0800 Subject: Re: [PATCH v2] f2fs: fix the periodic wakeups of discard thread To: Sahitya Tummala , Jaegeuk Kim , CC: References: <20210316093406.GC8562@codeaurora.org> <1617700156-19719-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: Date: Tue, 6 Apr 2021 17:29:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1617700156-19719-1-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/4/6 17:09, Sahitya Tummala wrote: > Fix the unnecessary periodic wakeups of discard thread that happens under > below two conditions - > > 1. When f2fs is heavily utilized over 80%, the current discard policy > sets the max sleep timeout of discard thread as 50ms > (DEF_MIN_DISCARD_ISSUE_TIME). But this is set even when there are > no pending discard commands to be issued. > > 2. In the issue_discard_thread() path when there are no pending discard > commands, it fails to reset the wait_ms to max timeout value. > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu Thanks,