Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH][next] iio: hrtimer-trigger: Fix potential integer
 overflow in iio_hrtimer_store_sampling_frequency
To:     Jonathan Cameron <jic23@kernel.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc:     Lars-Peter Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210329205817.GA188755@embeddedor>
 <20210405172646.6a9f1b7d@jic23-huawei>
From:   "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Message-ID: <ec7abed3-1685-8ae0-1a89-d9fc4ee76275@embeddedor.com>
Date:   Tue, 6 Apr 2021 05:13:38 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210405172646.6a9f1b7d@jic23-huawei>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/5/21 11:26, Jonathan Cameron wrote:
> On Mon, 29 Mar 2021 15:58:17 -0500
> "Gustavo A. R. Silva" <gustavoars@kernel.org> wrote:
> 
>> Add suffix ULL to constant 1000 in order to avoid a potential integer
>> overflow and give the compiler complete information about the proper
>> arithmetic to use. Notice that this constant is being used in a context
>> that expects an expression of type unsigned long long, but it's
>> currently evaluated using 32-bit arithmetic.
>>
>> Addresses-Coverity-ID: 1503062 ("Unintentional integer overflow")
>> Fixes: dafcf4ed8392 ("iio: hrtimer: Allow sub Hz granularity")
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> 
> Thanks, Applied to the togreg branch of iio.git and pushed out as testing
> for 0-day to poke at it.

Awesome. :)

Thanks, Jonathan.

--
Gustavo