Date: Wed, 11 Oct 2006 13:19:35 -0700
From: Andrew Morton <akpm@osdl.org>
To: Joel Becker <Joel.Becker@oracle.com>
Cc: Chandra Seetharaman <sekharan@us.ibm.com>, ckrm-tech@lists.sourceforge.net,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Allow more than PAGESIZE data read in configfs
Message-Id: <20061011131935.448a8696.akpm@osdl.org>
In-Reply-To: <20061010203511.GF7911@ca-server1.us.oracle.com>
References: <20061010182043.20990.83892.sendpatchset@localhost.localdomain>
	<20061010203511.GF7911@ca-server1.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1220
Lines: 28

On Tue, 10 Oct 2006 13:35:11 -0700
Joel Becker <Joel.Becker@oracle.com> wrote:

> On Tue, Oct 10, 2006 at 11:20:43AM -0700, Chandra Seetharaman wrote:
> > Currently, maximum amount of data that can be read from a configfs
> > attribute file is limited to PAGESIZE bytes. This is a limitation for
> > some of the usages of configfs.
> 
> 	NAK.  This forces a complex and inappropriate interface on the
> majority of users, and doesn't honor configfs' simplicity-first design.

The patch deletes a pile of custom code from configfs and replaces it with
calls to standard kernel infrastructure and fixes a shortcoming/bug in the
process.  Migration over to the new interface is trivial and almost
scriptable.

Nice patch.  What's not to like about it??

> 	I understand Chandra's concerns, but this patch isn't the right
> way to do it.

To do what?  Fix the artificial PAGE_SIZE contraint?  The patch would be
justified on cleanup grounds even if nobody was hitting that limit.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/