Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp20473pxf; Tue, 6 Apr 2021 13:45:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyD1E3SuHX1zM50mDtZKccACRT0lHTZV2ccAXuXg6pZCLY2i/oHMDIw2cwtMenpbNX5SuN7 X-Received: by 2002:a05:6402:1393:: with SMTP id b19mr186210edv.333.1617741920931; Tue, 06 Apr 2021 13:45:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617741920; cv=none; d=google.com; s=arc-20160816; b=NvycJpQSWUKyC7OY0YnkQdeqkm7jJtBJKQrl7DxiRezODji/+De34sIPNzjUROfA8R NKx6Fbh6dR3vytZrmdEhUdgq0Ld/IxHKaJLmA5DyN59KcLLOx61KxGXtLPsWL+S37orC d5PECgot17tJ4w+9IL0nzknlgKuixIZMt203e/enaYG/RHEQ4TiOAl3aEOzxrEOa8MSi m8Io5TJetRdCBVXYkz4LvyaVrZoP8Uad2ROaA0v8bybltdIEX0otmoWNt8K65ZZ28Hel ExwWJIl1XLkRXxcRTLVVbn470K7hAFZAuSbVYPEVYBVQDKTOknlMnVSTk+D17drGBfva IoZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=TkXDVf6bgWu81uCcatzNOikPiUaDi0mBJ2gitFtjnug=; b=yuEdOSrk1dLVCtUp/i/P2SKUY1AlsQ+luXed0YnjgxROAWAu+4g+7fCQTSa/bFCGUW 5wr80ItF1A5fX9GrFCWW31KmgYXZJqP7V64gjl4ckq6LxusHL/95ivJ7uU7n0em5uJKd ysiI4HR07rX7V2Vb8P8MqW8Fiz8qWttDi4B/ox+0fB/RF1JlBeYX2mghNkSdlN0XaNrt fvcL9oCz3iKk9esgp/qI/2Ic7mB5WSMge8f8YUos8ttRjjp4JvVP+Rw64tt4H9nVQ1b3 x6N7AI+Q0A+jgKrZjdzzfAFiPeQqw+oXGqnTHdrR6f7qJoYXmTK7c6qV1vpd/ntGP83i xIRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si20512753ejm.206.2021.04.06.13.44.33; Tue, 06 Apr 2021 13:45:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232724AbhDFL2X (ORCPT + 99 others); Tue, 6 Apr 2021 07:28:23 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:16358 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245518AbhDFL1p (ORCPT ); Tue, 6 Apr 2021 07:27:45 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FF4vQ1YNDz94BX; Tue, 6 Apr 2021 19:25:22 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Tue, 6 Apr 2021 19:27:25 +0800 From: Xiaofei Tan To: , CC: , , Xiaofei Tan Subject: [PATCH v2 09/10] tty: tty_ldisc: Do not use assignment in if condition Date: Tue, 6 Apr 2021 19:24:47 +0800 Message-ID: <1617708288-14847-10-git-send-email-tanxiaofei@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1617708288-14847-1-git-send-email-tanxiaofei@huawei.com> References: <1617708288-14847-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Do not use assignment in if condition following the advice of checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index 874d238..56e67f7 100644 --- a/drivers/tty/tty_ldisc.c +++ b/drivers/tty/tty_ldisc.c @@ -508,7 +508,8 @@ static int tty_ldisc_failto(struct tty_struct *tty, int ld) return PTR_ERR(disc); tty->ldisc = disc; tty_set_termios_ldisc(tty, ld); - if ((r = tty_ldisc_open(tty, disc)) < 0) + r = tty_ldisc_open(tty, disc); + if (r < 0) tty_ldisc_put(disc); return r; } -- 2.8.1